Minor dashboard fixes #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
koonpeng
requested changes
Aug 7, 2024
packages/dashboard/index.html
Outdated
| @@ -2,7 +2,7 @@ | |||
| <html lang="en"> | |||
| <head> | |||
| <meta charset="utf-8" /> | |||
| <link rel="icon" href="/favicon.ico" /> | |||
| <link rel="icon" href="favicon.ico" /> | |||
There was a problem hiding this comment.
Suggested change
| <link rel="icon" href="favicon.ico" /> | |
| <link rel="icon" href="%BASE_URL%favicon.ico" /> |
As shown in vite docs, seems that it expects base url to always end with a trailing slash https://vitejs.dev/config/shared-options#base. So we may need to update the app-config, we can also probably simplify url.ts with this assumption.
There was a problem hiding this comment.
thanks for the reference, changed in 8e6d672
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
koonpeng
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
Self-checks