-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce schemas for robot commission request #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
5 tasks
Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
aaronchongth
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and working well, thanks!
mxgrey
added a commit
that referenced
this pull request
Apr 8, 2024
* Introduce robot commission request+response Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Fix robot_commission_request type literal Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Include commission information in state Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Tweaks to message definitions Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Fix robot_commission_response properties Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Require a result for the commission field Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> --------- Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
mxgrey
added a commit
that referenced
this pull request
Apr 8, 2024
* Introduce robot commission request+response Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Fix robot_commission_request type literal Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Include commission information in state Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Tweaks to message definitions Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Fix robot_commission_response properties Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Require a result for the commission field Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> --------- Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A commission request feature is being added to
rmf_fleet_adapter
that will allow users to change the commissioning of a robot. Commissioning means whether the robot is willing to accept dispatched tasks or direct tasks. This will also allow the idle behavior of the robot to be toggled on and off.These features will help operators to stop a robot from receiving any further tasks and reassign tasks that the robot already had in situations where the robot must be taken out of commission temporarily.