Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mismatching version between github release and versions.h #1571

Open
JanFellner opened this issue Sep 19, 2024 · 1 comment
Open

Mismatching version between github release and versions.h #1571

JanFellner opened this issue Sep 19, 2024 · 1 comment

Comments

@JanFellner
Copy link

Whats now the version ;)
github says 1.9.6
versions.h says 1.9.7 but jumps from 1.9.5 to 1.9.7 so i assume the versions.h is wrong?
@baylesj
Copy link
Contributor

baylesj commented Sep 25, 2024

Tip of tree should be after 1.9.6, so tip of tree should be 1.9.7.

The released branch should be 1.9.6. There have been some versioning number mismatches I am looking to address at some point soon.

I'll likely roll another release soon due to these and some related issues.

sfan5 added a commit to sfan5/minetest that referenced this issue Oct 12, 2024
@sfan5
Update jsoncpp copy to 1.9.6
29cd699 
note: the version number is different due to open-source-parsers/jsoncpp#1571
sfan5 added a commit to minetest/minetest that referenced this issue Oct 13, 2024
@sfan5
Update jsoncpp copy to 1.9.6
dbbe0ca 
note: the version number is different due to open-source-parsers/jsoncpp#1571
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@baylesj @JanFellner