Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/Set graph retention rates to 1 if no reviews occured #405

Merged
merged 4 commits into from
May 10, 2024

Conversation

FSchliephacke
Copy link
Contributor

A simple solution for #404

@L-M-Sherlock
Copy link
Member

The SQL is hard to read. An alternative method is to add 1 to the denominator and the numerator.

@user1823
Copy link
Contributor

user1823 commented May 8, 2024

Instead of modifying the SQL query, you can probably add a condition just after line 212.

offset_retention_review_cnt = mw.col.db.all(query)

@L-M-Sherlock
Copy link
Member

Patch: fsrs4anki-helper.ankiaddon.zip

This patch may also solve your issue. Could you help me test it?

@L-M-Sherlock L-M-Sherlock requested a review from user1823 May 10, 2024 02:07
Copy link
Contributor

@user1823 user1823 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Before:

After:

@L-M-Sherlock L-M-Sherlock merged commit 82e2ffa into open-spaced-repetition:main May 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Set graph retention rates to 1 if no reviews occured
3 participants