Feat/preset level easy days #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user1823
suggested changes
Nov 30, 2024
| tooltip("Please enable load balance first") | ||
| return | ||
| if ( | ||
| all([r == 1 for r in config.easy_days_review_ratio_list]) |
There was a problem hiding this comment.
We need something to replace this. In the current patch, if I click "Apply easy days now" without selecting any easy day, I don't get any error.
There was a problem hiding this comment.
As I mentioned before, I have to check deck by deck to know whether user selects any easy days.
And it's reasonable to not get any error without selecting any easy days because the user may just want to reset their changes in easy days.
user1823
approved these changes
Dec 1, 2024
|
I don't use Easy Days either |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the smart fuzz has been built-in, so the load balance option has been removed. The load balance and easy days are always applied when rescheduling via the helper add-on.
Patch: fsrs4anki-helper.ankiaddon.zip
After this PR, I will release a new branch in Ankiweb.
The new branch will only support Anki 24.11+ versions.