Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/recommended steps #508

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Feat/recommended steps #508

merged 2 commits into from
Dec 4, 2024

Conversation

L-M-Sherlock
Copy link
Member

@L-M-Sherlock L-M-Sherlock added the enhancement New feature or request label Dec 3, 2024
@Expertium
Copy link
Contributor

Expertium commented Dec 3, 2024

image

Suggestion: if recommended learning steps are <10s, just display "Not needed" or something like that

Also, why does it sometimes suggest one learning step, and sometimes two?

@L-M-Sherlock
Copy link
Member Author

Also, why does it sometimes suggest one learning step, and sometimes two?

If the 2nd learning step is longer than the cutoff, it will be hidden.

@user1823
Copy link
Contributor

user1823 commented Dec 3, 2024

Suggestion: if recommended learning steps are <10s, just display "Not needed" or something like that

Why?

Copy link
Contributor

@user1823 user1823 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally, LGTM.

Just being curious. Why is the code written in JS rather than Python?

@Expertium
Copy link
Contributor

Why?

Because <10s is useless

@user1823
Copy link
Contributor

user1823 commented Dec 3, 2024

Because <10s is useless

In that case, instead of suggesting the user to remove the steps completely, shouldn't we suggest them a slightly longer but more reasonable step (e.g., 10s or 15s)?

@L-M-Sherlock
Copy link
Member Author

Just being curious. Why is the code written in JS rather than Python?

It's not written by me. I guess only JS could do such a reactive interaction in this page.

@L-M-Sherlock
Copy link
Member Author

L-M-Sherlock commented Dec 4, 2024

Because <10s is useless

Instead, I think 10s is necessary. If the stability is 10s, the user only recalls 90% in 10s.

@L-M-Sherlock L-M-Sherlock merged commit b13eb9e into main Dec 4, 2024
2 checks passed
@L-M-Sherlock L-M-Sherlock deleted the Feat/recommended-steps branch December 4, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants