Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/Steps Stats for Good Then Again #514

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

L-M-Sherlock
Copy link
Member

patch: fsrs4anki-helper.ankiaddon.zip

preview:

image

Color suggestion wanted.

@L-M-Sherlock L-M-Sherlock added the enhancement New feature or request label Dec 5, 2024
@L-M-Sherlock L-M-Sherlock linked an issue Dec 5, 2024 that may be closed by this pull request
@L-M-Sherlock L-M-Sherlock merged commit 8919e54 into main Dec 5, 2024
2 checks passed
@L-M-Sherlock L-M-Sherlock deleted the Feat/Step-Stats-for-Good-Then-Again branch December 5, 2024 15:17
@aleksejrs
Copy link

"Good Then Again" and "Lapse" look distinct from the rest of the table's lines.

@aleksejrs
Copy link

How about coloring the words in them like they are colored in their own rows? If needed, consider giving the "Then" regular weight.

@aleksejrs
Copy link

But I haven't even thought about what it means. I guess "Good Then Again" is for the stability after "Again" that happened after "Good".

@L-M-Sherlock
Copy link
Member Author

I guess "Good Then Again" is for the stability after "Again" that happened after "Good".

"Good Then Again" is for the stability where you firstly rate "Good" then rate "Again" in a new card.

@L-M-Sherlock
Copy link
Member Author

image

How about that?

@aleksejrs
Copy link

aleksejrs commented Dec 13, 2024

Looks OK.
Although the yellow is too light on light gray.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add Good then Again Stat in Steps Stats
2 participants