fix nil pointer dereference in supervisor example #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR @haoqixu Can you provide a test that reproduces this bug? |
|
The example in https://opentelemetry.io/blog/2022/opamp/ can reproduce this bug. |
|
@haoqixu thanks for the link. Sorry I was not clear. To accept a bug fix ideally we need an automated test that shows that the bug exists and verifies that the PR fixes it. Will you be able to write a test like that and include in this PR? |
|
PTAL |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #166 +/- ##
==========================================
+ Coverage 76.11% 76.52% +0.40%
==========================================
Files 24 24
Lines 1834 1866 +32
==========================================
+ Hits 1396 1428 +32
- Misses 326 327 +1
+ Partials 112 111 -1
☔ View full report in Codecov by Sentry. |
Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
tigrannajaryan
approved these changes
Jun 18, 2023
tigrannajaryan
pushed a commit
to tigrannajaryan/opamp-go
that referenced
this pull request
Jun 19, 2023
`Supervisor.healthCheckTicker` is prepared in `(*Supervisor).startAgent`. If there is no effective config file, we will skip the call of `startAgent` causing an nil pointer dereference in the loop.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supervisor.healthCheckTickeris prepared in(*Supervisor).startAgent. If there is no effective config file, we will skip the call ofstartAgentcausing an nil pointer dereference in the loop.