-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OnCommand is ignored for when AcceptsCommands not set #189
OnCommand is ignored for when AcceptsCommands not set #189
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #189 +/- ##
==========================================
- Coverage 76.11% 75.24% -0.88%
==========================================
Files 24 24
Lines 1834 1874 +40
==========================================
+ Hits 1396 1410 +14
- Misses 326 345 +19
- Partials 112 119 +7
☔ View full report in Codecov by Sentry. |
r.rcvCommand(msg.Command) | ||
// If a command message exists, other messages will be ignored | ||
return | ||
if r.hasCapability(protobufs.AgentCapabilities_AgentCapabilities_AcceptsRestartCommand) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it would be useful to add a comment that says when any new command capabilities are added they need to be checked here. I am not sure what's the best way to ensure we don't forget to do it, but a comment may help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added note
Fixes #188