Change callback signatures to pass down context where applicable #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
==========================================
+ Coverage 72.50% 72.79% +0.28%
==========================================
Files 25 25
Lines 2022 2025 +3
==========================================
+ Hits 1466 1474 +8
+ Misses 446 442 -4
+ Partials 110 109 -1 ☔ View full report in Codecov by Sentry. |
jaronoff97
commented
Jan 22, 2024
| srv.OnMessage = func(msg *protobufs.AgentToServer) *protobufs.ServerToAgent { | ||
| rcvAgentInstanceUid.Store(msg.InstanceUid) | ||
| if sentInvalidId.Load() { |
There was a problem hiding this comment.
codecov was complaining that this was untested, so i added something that forced an error for an empty string and then resolves it. This will trigger the error checking logic.
gdfast
approved these changes
Jan 22, 2024
andykellr
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes a few server callback interface methods to pass down a context to propagate request information effectively. This closes #214