Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade OTel SDK dependencies in the internal/example module #264

Merged

Conversation

gdfast
Copy link
Contributor

@gdfast gdfast commented Mar 19, 2024

Problem
The example code has a number of dependencies on otel packages that are either deprecated or very old. This makes developing and improving the examples challenging, and also doesn't make for the best examples for new users.

Solution

  • Upgrade the OTel packages to v1.24.0 (the latest version)
  • Remove old and deprecated dependent modules where possible

*Problem*
The example code has a number of dependencies on otel packages that are either deprecated or very old. This makes developing and improving the examples challenging, and also doesn't make for the best examples for new users.

*Solution*
- Upgrade the OTel packages to v1.24.0 (the latest version)
- Remove old and deprecated dependent modules where possible
@gdfast gdfast requested a review from a team March 19, 2024 20:32
@tigrannajaryan
Copy link
Member

Thank you @gdfast

If you haven't already please also run go mod tidy in the example directory.

@tigrannajaryan
Copy link
Member

@arminru we have a codecov report failing with some message about keys. I remember you were doing something with tokens a few days ago.

Can this be the reason it fails? https://github.com/open-telemetry/opamp-go/actions/runs/8349792083/job/22871138122?pr=264

@arminru
Copy link
Member

arminru commented Mar 20, 2024

@tigrannajaryan the token should be available via the org secret already but the workflow probably needs to be configured to actually use it. The action might also need an update at some point.

https://docs.codecov.com/docs/adding-the-codecov-token

@arminru
Copy link
Member

arminru commented Mar 20, 2024

@tigrannajaryan I just checked the workflow yaml and it's already set up correctly. The token itself was the problem, seems like the repo had its own invalid or expired token configured locally that was overriding the org secret. I deleted it, now it should work.

Screenshot_20240320-092201~2.png

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.70%. Comparing base (ba70a24) to head (e9ba9f0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
- Coverage   74.83%   74.70%   -0.13%     
==========================================
  Files          25       25              
  Lines        1625     1625              
==========================================
- Hits         1216     1214       -2     
- Misses        297      299       +2     
  Partials      112      112              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tigrannajaryan
Copy link
Member

Great, thanks @arminru !

@gdfast
Copy link
Contributor Author

gdfast commented Mar 20, 2024

Thank you @gdfast

If you haven't already please also run go mod tidy in the example directory.

✔️ I did this before pushing

@tigrannajaryan tigrannajaryan merged commit d1d6081 into open-telemetry:main Mar 20, 2024
6 of 7 checks passed
@gdfast gdfast deleted the gfast-upgrade-example-otel-deps branch March 20, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants