-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade OTel SDK dependencies in the internal/example module #264
Upgrade OTel SDK dependencies in the internal/example module #264
Conversation
*Problem* The example code has a number of dependencies on otel packages that are either deprecated or very old. This makes developing and improving the examples challenging, and also doesn't make for the best examples for new users. *Solution* - Upgrade the OTel packages to v1.24.0 (the latest version) - Remove old and deprecated dependent modules where possible
Thank you @gdfast If you haven't already please also run |
@arminru we have a codecov report failing with some message about keys. I remember you were doing something with tokens a few days ago. Can this be the reason it fails? https://github.com/open-telemetry/opamp-go/actions/runs/8349792083/job/22871138122?pr=264 |
@tigrannajaryan the token should be available via the org secret already but the workflow probably needs to be configured to actually use it. The action might also need an update at some point. |
@tigrannajaryan I just checked the workflow yaml and it's already set up correctly. The token itself was the problem, seems like the repo had its own invalid or expired token configured locally that was overriding the org secret. I deleted it, now it should work. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #264 +/- ##
==========================================
- Coverage 74.83% 74.70% -0.13%
==========================================
Files 25 25
Lines 1625 1625
==========================================
- Hits 1216 1214 -2
- Misses 297 299 +2
Partials 112 112 ☔ View full report in Codecov by Sentry. |
Great, thanks @arminru ! |
✔️ I did this before pushing |
Problem
The example code has a number of dependencies on otel packages that are either deprecated or very old. This makes developing and improving the examples challenging, and also doesn't make for the best examples for new users.
Solution