Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update opentelemetry.instrumentation.alpha to v2.6.0-alpha #483

Merged
merged 3 commits into from
Jul 20, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 17, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
io.opentelemetry.instrumentation:opentelemetry-okhttp-3.0 2.5.0-alpha -> 2.6.0-alpha age adoption passing confidence
io.opentelemetry.instrumentation:opentelemetry-instrumentation-api-incubator 2.5.0-alpha -> 2.6.0-alpha age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team July 17, 2024 03:28
@renovate renovate bot force-pushed the renovate/opentelemetry.instrumentation.alpha branch from 175c24c to c8182e1 Compare July 17, 2024 07:11
Copy link
Contributor Author

renovate bot commented Jul 18, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@breedx-splk
Copy link
Contributor

Just for the record, the internal APIs changed due to open-telemetry/opentelemetry-java-instrumentation#11620

OkHttpInstrumentationConfig
.getCapturedResponseHeaders())
.setKnownMethods(OkHttpInstrumentationConfig.getKnownMethods())
// TODO: Do we really need to set the known methods on the span
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I think about it better, I'm not sure if any of our users would ever need to change the known HTTP method names overall... I guess it's there because there's a setter for it in the instrumentation lib, though apart from that, I don't think there's any reason to override the names either for the inst builder or for the span name extractor. 🤔

@breedx-splk breedx-splk merged commit 3579223 into main Jul 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants