Demo app: don't start the main activity again, just finish the current one #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I agree we shouldn't relaunch the main activity, so thanks for these changes! However, I was also curious why doing so would trigger a new app launch event. I found this part of the code where I think it's happening and it looks like the logic is to create the event every time the "initial activity" starts, which doesn't seem like a good idea to trigger it (there are also some comments there acknowledging so) so maybe we should do some work in the future to properly cover the "hot" app start case. |
LikeTheSalad
approved these changes
Sep 19, 2024
breedx-splk
approved these changes
Sep 19, 2024
|
I opened this issue to track the AppStart thing: #606 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically the title. I don't think we should be starting the main activity again, when clicking the
Exitbutton on another activity. Just finishing the current activity seems to work fine. The motivation to look into this were multipleApp startspans emitted by the app. After those changes it doesn't happen, there areRestartedspans for the main activity instead. The behaviour after the change is identical to the one using the phone's build-in "go back" button while on the first screen of a non-main activity.