This repository has been archived by the owner on Oct 29, 2021. It is now read-only.
Remove Core from Module type #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
u5surf
requested review from
a team,
bogdandrutu and
jpkrohling
and removed request for
a team
jpkrohling
reviewed
Oct 5, 2021
| @@ -64,7 +64,6 @@ type Module struct { | |||
| Import string `mapstructure:"import"` // if not specified, this is the path part of the go mods | |||
| GoMod string `mapstructure:"gomod"` // a gomod-compatible spec for the module | |||
| Path string `mapstructure:"path"` // an optional path to the local version of this module | |||
| Core bool `mapstructure:"core"` // whether this module comes from core, meaning that no further dependencies will be added | |||
There was a problem hiding this comment.
I would say that we should keep this property for a couple of releases, telling users what to use instead.
jpkrohling
reviewed
Oct 11, 2021
jpkrohling
reviewed
Oct 13, 2021
jpkrohling
previously approved these changes
Oct 14, 2021
internal/builder/config_test.go
Outdated
| assert.Empty(t, cfg.Extensions[0].GoMod) | ||
| } | ||
|
|
||
| func TestDepricatedCore(t *testing.T) { |
There was a problem hiding this comment.
Suggested change
| func TestDepricatedCore(t *testing.T) { | |
| func TestDeprecatedCore(t *testing.T) { |
internal/builder/config_test.go
Outdated
| Extensions: []Module{ | ||
| { | ||
| Import: "go.opentelemetry.io/collector/receiver/jaegerreceiver", | ||
| GoMod: "go.opentelemetry.io/collector v0.36.0", |
There was a problem hiding this comment.
Can you remove this line? Previously, only the import and "core" were required, and this test would reflect that.
Fixes open-telemetry#15 Signed-off-by: yugo-horie <u5.horie@gmail.com>
jpkrohling
approved these changes
Oct 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15
I supposed to rewrite
TestModuleFromCorefollowing #12 (comment)Signed-off-by: yugo-horie u5.horie@gmail.com