Skip to content

Commit

Permalink
Adding message to check to highlight what needs to be done
Browse files Browse the repository at this point in the history
  • Loading branch information
MovieStoreGuy committed Dec 22, 2021
1 parent 8fc083d commit c51624c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion internal/components/exporters_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ func TestDefaultExporters(t *testing.T) {
},
}

assert.Equal(t, len(tests)+0 /* not tested */, len(expFactories))
assert.Equal(t, len(tests), len(expFactories), "All user configureable components must be added to the lifecycle test")
for _, tt := range tests {
t.Run(string(tt.exporter), func(t *testing.T) {
t.Parallel()
Expand Down
8 changes: 4 additions & 4 deletions internal/coreinternal/testutil/testutil_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@ func TestTemporaryFile(t *testing.T) {
assert.ErrorIs(t, err, os.ErrNotExist)
}

func TestTemporaryDirectory(t *testing.T) {
var tmp string
func TestTemporaryDirectory(t *testing.T) {
var tmp string

t.Run("scoped lifetime", func(t *testing.T) {
tmp = NewTemporaryDirectory(t)
Expand All @@ -101,7 +101,7 @@ func TestTemporaryDirectory(t *testing.T) {
assert.NoError(t, err)
assert.True(t, stat.IsDir(), "Must have the directory permissions set")
})

_, err := os.Stat(tmp)
assert.ErrorIs(t, err, os.ErrNotExist)
}
}

0 comments on commit c51624c

Please sign in to comment.