Bump github.com/aerospike/aerospike-client-go/v6 from 6.13.0 to 6.14.0 causes issues

[codeboten]

Component(s)

receiver/aerospike

Describe the issue you're reporting

See https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/6015671753/job/16318410285?pr=26262 for more details:

go: downloading github.com/mattn/go-sqlite3 v2.0.3+incompatible
mkdir -p /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/coverage/unit
go test -race -timeout 300s -parallel 4 --tags="" -cover ./... -covermode=atomic -args -test.gocoverdir="/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/coverage/unit"
# github.com/mattn/go-sqlite3
sqlite3-binding.c: In function ‘sqlite3SelectNew’:
sqlite3-binding.c:128049:10: warning: function may return address of local variable [-Wreturn-local-addr]
128049 |   return pNew;
       |          ^~~~
sqlite3-binding.c:128009:10: note: declared here
128009 |   Select standin;
       |          ^~~~~~~
panic: proto: file "rpc/rpc.proto" has a name conflict over DEFAULT
	previously from: "github.com/aerospike/aerospike-client-go/v6/proto/kvs"
	currently from:  "github.com/checkpoint-restore/go-criu/v5/rpc"
See https://protobuf.dev/reference/go/faq#namespace-conflict

[github-actions]

Pinging code owners:

• receiver/aerospike: @djaglowski @antonblock

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[antonblock]

aerospike/aerospike-client-go#414

[crobert-1]

Looks like this is a valid issue in the dependency so I'll remove the needs-triage label.

[crobert-1]

/label -needs-triage

[djaglowski]

I'll take a look at this.

[djaglowski]

@dwelch-spike, any ideas?

[dwelch-spike]

@djaglowski I'll bring the proto name issue up with the Go client developer, @khaf.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• receiver/aerospike: @djaglowski @antonblock

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[TylerHelmuth]

I think this will get resolved with #30261, which requires use to bump our go version to 1.21

[khaf]

I'll try to backport most of the Aerospike Go Client v7 changeset to the v6. Hopefully that will resolve this ticket.

[khaf]

This issue should be addressed in the Aerospike Go Client v6.15.0. Let me know how it goes.

[TylerHelmuth]

PR that does the bump: #30785

[djaglowski]

Seems there may be a problem with the updated library. From CI failure on #30785:

panic: proto: file "kv.proto" has a name conflict over DEFAULT
	previously from: "github.com/checkpoint-restore/go-criu/v5/rpc"
	currently from:  "github.com/aerospike/aerospike-client-go/v6/proto/kvs"
See https://protobuf.dev/reference/go/faq#namespace-conflict

[khaf]

I now see what's going on. The manifest used for the Aerospike Proxy Server does not state a package name, in effect using the Global Namespace. That's unfortunate, since it is not in my control. I'll ask my colleagues to address the issue. In the mean time, I'll see if I can provide a flag to exclude the Proxy server during build.

[TylerHelmuth]

@khaf got the same error when using v7: #31270

[TylerHelmuth]

Still experiencing problems with bumps to v6.15.1 and v7.4.0 after configschema was removed:

• [chore] Bump github.com/aerospike/aerospike-client-go from 6.13.0 to 6.15.1 #33394
• [chore] Bump github.com/aerospike/aerospike-client-go from 6.13.0 to 7.4.0 #33392

[djaglowski]

Closing in favor of #34244