Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github add-labels script references non-existent ping-codeowners.sh script #26361

Closed
crobert-1 opened this issue Aug 31, 2023 · 2 comments · Fixed by #26362
Closed

Github add-labels script references non-existent ping-codeowners.sh script #26361

crobert-1 opened this issue Aug 31, 2023 · 2 comments · Fixed by #26362
Labels
needs triage New item requiring triage

Comments

@crobert-1
Copy link
Member

crobert-1 commented Aug 31, 2023 •
edited
Loading

Component(s)

No response

Describe the issue you're reporting

When attempting to add a component label to an open issue by leaving a comment, the add-labels.sh script fails trying to ping the codeowners of the component.

Failure reference

Failure output:

Run ./.github/workflows/scripts/add-labels.sh
https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/2453[9](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/6040791721/job/16392379955#step:4:10)
bash: ./.github/workflows/scripts/ping-codeowners.sh: No such file or directory
Error: Process completed with exit code 127.

Line failing is found here.

        # Labels added by a GitHub Actions workflow don't trigger other workflows
        # by design, so we have to manually ping code owners here.
        COMPONENT="${LABEL}" ISSUE=${ISSUE} SENDER="${SENDER}" bash "${CUR_DIRECTORY}/ping-codeowners.sh"

There is no ping-codeowners.sh file, but there are ping-codeowners-issues.sh, ping-codeowners-on-new-issue.sh, and ping-codeowners-prs.sh in this directory.

I believe ping-codeowners.sh should be updated to be ping-codeowners-issues.sh, but I'd have to test to make sure.
@crobert-1 crobert-1 added the needs triage New item requiring triage label Aug 31, 2023
@crobert-1
Copy link
Member Author

It looks like the add-labels and ping-codeowners workflows were initially added in #12478. From there, in #16175, ping-codeowners was simply renamed to be ping-codeowners-issues, without updating the add-labels workflow reference.

From this, I believe we need to update the failing line to point to the ping-codeowners-issues workflow instead.

@crobert-1 crobert-1 mentioned this issue Aug 31, 2023
Merged
evan-bradley pushed a commit that referenced this issue Aug 31, 2023
@crobert-1
[chore] Fix GitHub add-label workflow to ping codeowners (#26362)
4fabc48 
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
The add-label workflow is used by GitHub when manually adding labels to
issues. When adding a new component to an issue, the workflow attempts
to ping codeowners of the given component. However, the link to the ping
codeowners script was outdated, and was failing. This change references
the moved script.

**Link to tracking Issue:** <Issue number if applicable>
Resolves #26361

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>
@crobert-1
Copy link
Member Author

Confirmed it's working as expected now: #23236 (comment)

This was referenced Sep 3, 2023
Open
Open
@github-actions github-actions bot mentioned this issue Sep 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs triage New item requiring triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chore] Fix GitHub add-label workflow to ping codeowners crobert-1/opentelemetry-collector-contrib
1 participant
@crobert-1