Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8scluster receiver k8s.pod.qos_class resource attribute #27483

Closed
povilasv opened this issue Oct 9, 2023 · 4 comments
Closed

k8scluster receiver k8s.pod.qos_class resource attribute #27483

povilasv opened this issue Oct 9, 2023 · 4 comments
Assignees
Labels

Comments

@povilasv
Copy link
Contributor

povilasv commented Oct 9, 2023

Component(s)

receiver/k8scluster

Is your feature request related to a problem? Please describe.

I would like to do some aggregations on Kubernetes Pod QOS class using k8sclusterreceiver.

Kube State Metrics has a metric:

kube_pod_status_qos_class{class="Guaranteed|Burstable|BestEffort"}

I would like to have a similar feature, but instead we could add it as resource attribute. Users then could use transformation processor to make it a standalone metric.

Describe the solution you'd like

I suggest we add:

k8s.pod.qos_class optional (disabled by default) resource attribute, with one of the values Guaranteed|Burstable|BestEffort

Describe alternatives you've considered

Additional context

Related: #21234

@povilasv povilasv added enhancement New feature or request needs triage New item requiring triage labels Oct 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@dmitryax
Copy link
Member

dmitryax commented Oct 10, 2023

Sounds like a reasonable addition as an optional resource attribute. @TylerHelmuth @jinja2 WDYT?

@jinja2
Copy link
Contributor

jinja2 commented Oct 10, 2023

Sounds good

@povilasv
Copy link
Contributor Author

Thanks for comments, opened PR -> #27485 :)

@TylerHelmuth TylerHelmuth added priority:p2 Medium and removed needs triage New item requiring triage labels Oct 10, 2023
TylerHelmuth pushed a commit that referenced this issue Oct 12, 2023
#27485)

**Description:** <Describe what has changed.>

add k8s.pod.qos_class optional resource attriute

**Link to tracking Issue:** <Issue number if applicable>

#27483

**Testing:** <Describe what testing was performed and which tests were
added.>
- updated unit tests

**Documentation:** <Describe the documentation added.>

- generated
JaredTan95 pushed a commit to openinsight-proj/opentelemetry-collector-contrib that referenced this issue Oct 18, 2023
open-telemetry#27485)

**Description:** <Describe what has changed.>

add k8s.pod.qos_class optional resource attriute

**Link to tracking Issue:** <Issue number if applicable>

open-telemetry#27483

**Testing:** <Describe what testing was performed and which tests were
added.>
- updated unit tests

**Documentation:** <Describe the documentation added.>

- generated
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this issue Nov 12, 2023
open-telemetry#27485)

**Description:** <Describe what has changed.>

add k8s.pod.qos_class optional resource attriute

**Link to tracking Issue:** <Issue number if applicable>

open-telemetry#27483

**Testing:** <Describe what testing was performed and which tests were
added.>
- updated unit tests

**Documentation:** <Describe the documentation added.>

- generated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants