Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The main branch of opentelemetry-collector does not contain the path docs/performance.md #29341

Closed
jshawatsplunk opened this issue Nov 18, 2023 · 1 comment · Fixed by #29344
Closed

The main branch of opentelemetry-collector does not contain the path docs/performance.md #29341

jshawatsplunk opened this issue Nov 18, 2023 · 1 comment · Fixed by #29344
Assignees
@JaredTan95
Labels
bug Something isn't working

Comments

@jshawatsplunk
Copy link

Component(s)

No response

What happened?

Description

main branch of opentelemetry-collector does not contain the path docs/performance.md.
The repo https://github.com/open-telemetry/opentelemetry-collector-contrib displays a Performance link that is broken.

Steps to Reproduce

Click on Performance in the repo README.md https://github.com/open-telemetry/opentelemetry-collector-contrib

Expected Result

Link works to performance considerations or sizing recommendations page. Perhaps:
https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/monitoring.md

Actual Result

404

Collector version

v0.89.0

Environment information

n/a

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response
@jshawatsplunk jshawatsplunk added bug Something isn't working needs triage New item requiring triage labels Nov 18, 2023
@JaredTan95
Copy link
Member

as open-telemetry/opentelemetry-collector@99a4825 removed, I think we need to remove it here.

@JaredTan95 JaredTan95 removed the needs triage New item requiring triage label Nov 20, 2023
@JaredTan95 JaredTan95 mentioned this issue Nov 20, 2023
Merged
@JaredTan95 JaredTan95 self-assigned this Nov 20, 2023
@github-actions github-actions bot mentioned this issue Nov 21, 2023
Closed
mx-psi pushed a commit that referenced this issue Nov 22, 2023
@JaredTan95 @crobert-1
[docs] Remove performance link (#29344)
f85a391 
**Description:** close
#29341
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

**Link to tracking Issue:** <Issue number if applicable>

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>

---------

Co-authored-by: Curtis Robert <crobert@splunk.com>
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this issue Nov 24, 2023
@JaredTan95 @crobert-1 @RoryCrispin
[docs] Remove performance link (open-telemetry#29344)
6559dd8 
**Description:** close
open-telemetry#29341
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

**Link to tracking Issue:** <Issue number if applicable>

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>

---------

Co-authored-by: Curtis Robert <crobert@splunk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JaredTan95 JaredTan95

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[docs] Remove performance link JaredTan95/opentelemetry-collector-contrib
2 participants
@JaredTan95 @jshawatsplunk