Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[processor/deltatocumulative] TestLimitEvict failure #33094

Closed
crobert-1 opened this issue May 16, 2024 · 4 comments · Fixed by #33266
Closed

[processor/deltatocumulative] TestLimitEvict failure #33094

crobert-1 opened this issue May 16, 2024 · 4 comments · Fixed by #33266
Labels
flaky test a test is flaky processor/deltatocumulative

Comments

@crobert-1
Copy link
Member

crobert-1 commented May 16, 2024 •
edited
Loading

Component(s)

processor/deltatocumulative

Describe the issue you're reporting

Failing CI/CD link

Failure output:

2024-05-16T11:51:49.6921550Z === �[31mFAIL�[0m: internal/streams TestLimitEvict (0.00s)
2024-05-16T11:51:49.6922918Z     limit_test.go:103: 
2024-05-16T11:51:49.6925903Z         	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/processor/deltatocumulativeprocessor/internal/streams/limit_test.go:103
2024-05-16T11:51:49.6929196Z make[2]: *** [../../Makefile.Common:131: test-with-cover] Error 1
2024-05-16T11:51:49.6930342Z make[1]: *** [Makefile:176: processor/deltatocumulativeprocessor] Error 2
2024-05-16T11:51:49.6931307Z         	Error:      	Not equal: 
2024-05-16T11:51:49.6937538Z         	            	expected: streams.ErrEvicted{ErrLimit:5, Ident:identity.Stream{metric:identity.Metric{scope:identity.Scope{resource:identity.Resource{attrs:[16]uint8{0xbb, 0xf0, 0xe8, 0xcf, 0x21, 0x1e, 0xca, 0xb1, 0xb6, 0xf9, 0x34, 0xfa, 0x9b, 0xab, 0x92, 0x23}}, name:"6da1", version:"799e", attrs:[16]uint8{0xda, 0x3, 0xee, 0x7a, 0xd6, 0x54, 0x10, 0x62, 0x18, 0xae, 0x64, 0xe7, 0xbf, 0x7f, 0x45, 0x57}}, name:"15fa", unit:"41b2", ty:2, monotonic:false, temporality:0}, attrs:[16]uint8{0x7, 0xb2, 0x82, 0xb5, 0x8e, 0xbc, 0xf0, 0x97, 0xb1, 0xa5, 0xd, 0x26, 0x2f, 0xb2, 0x0, 0xa2}}}
2024-05-16T11:51:49.6944990Z         	            	actual  : streams.ErrEvicted{ErrLimit:5, Ident:identity.Stream{metric:identity.Metric{scope:identity.Scope{resource:identity.Resource{attrs:[16]uint8{0xbb, 0xf0, 0xe8, 0xcf, 0x21, 0x1e, 0xca, 0xb1, 0xb6, 0xf9, 0x34, 0xfa, 0x9b, 0xab, 0x92, 0x23}}, name:"6da1", version:"799e", attrs:[16]uint8{0xda, 0x3, 0xee, 0x7a, 0xd6, 0x54, 0x10, 0x62, 0x18, 0xae, 0x64, 0xe7, 0xbf, 0x7f, 0x45, 0x57}}, name:"15fa", unit:"41b2", ty:2, monotonic:false, temporality:0}, attrs:[16]uint8{0x69, 0xdd, 0x57, 0x47, 0xf0, 0xeb, 0xde, 0xf8, 0x43, 0x67, 0xe6, 0x1a, 0x20, 0xea, 0x92, 0x7d}}}
2024-05-16T11:51:49.6947346Z         	            	
2024-05-16T11:51:49.6947858Z         	            	Diff:
2024-05-16T11:51:49.6948444Z         	            	--- Expected
2024-05-16T11:51:49.6948948Z         	            	+++ Actual
2024-05-16T11:51:49.6949577Z         	            	@@ -23,3 +23,3 @@
2024-05-16T11:51:49.6950204Z         	            	   attrs: ([16]uint8) (len=16) {
2024-05-16T11:51:49.6951272Z         	            	-   00000000  07 b2 82 b5 8e bc f0 97  b1 a5 0d 26 2f b2 00 a2  |...........&/...|
2024-05-16T11:51:49.6952448Z         	            	+   00000000  69 dd 57 47 f0 eb de f8  43 67 e6 1a 20 ea 92 7d  |i.WG....Cg.. ..}|
2024-05-16T11:51:49.6953109Z         	            	   }
2024-05-16T11:51:49.6953567Z         	Test:       	TestLimitEvict
2024-05-16T11:51:49.6953942Z 
2024-05-16T11:51:49.6954268Z === �[31mFAIL�[0m: internal/streams TestLimitEvict (re-run 1) (0.00s)
2024-05-16T11:51:49.6954852Z     limit_test.go:103: 
2024-05-16T11:51:49.6956515Z         	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/processor/deltatocumulativeprocessor/internal/streams/limit_test.go:103
2024-05-16T11:51:49.6957678Z         	Error:      	Not equal: 
2024-05-16T11:51:49.6962081Z         	            	expected: streams.ErrEvicted{ErrLimit:5, Ident:identity.Stream{metric:identity.Metric{scope:identity.Scope{resource:identity.Resource{attrs:[16]uint8{0x67, 0x1e, 0x6e, 0x96, 0xdd, 0x45, 0x96, 0xac, 0x4d, 0x87, 0x21, 0x8b, 0xf9, 0xcb, 0x84, 0xa3}}, name:"7907", version:"1b18", attrs:[16]uint8{0xad, 0xa5, 0xad, 0xfd, 0xfb, 0xb6, 0x70, 0x71, 0xf5, 0x8a, 0x48, 0x33, 0x88, 0xf0, 0xb, 0xab}}, name:"569c", unit:"3b25", ty:2, monotonic:false, temporality:0}, attrs:[16]uint8{0xe7, 0x6, 0x68, 0x4c, 0x11, 0x31, 0x91, 0x33, 0x89, 0x87, 0x4d, 0x2e, 0x4, 0xc3, 0x20, 0xa0}}}
2024-05-16T11:51:49.6968390Z         	            	actual  : streams.ErrEvicted{ErrLimit:5, Ident:identity.Stream{metric:identity.Metric{scope:identity.Scope{resource:identity.Resource{attrs:[16]uint8{0x67, 0x1e, 0x6e, 0x96, 0xdd, 0x45, 0x96, 0xac, 0x4d, 0x87, 0x21, 0x8b, 0xf9, 0xcb, 0x84, 0xa3}}, name:"7907", version:"1b18", attrs:[16]uint8{0xad, 0xa5, 0xad, 0xfd, 0xfb, 0xb6, 0x70, 0x71, 0xf5, 0x8a, 0x48, 0x33, 0x88, 0xf0, 0xb, 0xab}}, name:"569c", unit:"3b25", ty:2, monotonic:false, temporality:0}, attrs:[16]uint8{0x4c, 0x1a, 0xc, 0xe2, 0xcd, 0x53, 0x27, 0xeb, 0xea, 0x97, 0x5f, 0x10, 0xfe, 0xac, 0x21, 0xbd}}}
2024-05-16T11:51:49.6970895Z         	            	
2024-05-16T11:51:49.6971409Z         	            	Diff:
2024-05-16T11:51:49.6971938Z         	            	--- Expected
2024-05-16T11:51:49.6972418Z         	            	+++ Actual
2024-05-16T11:51:49.6973048Z         	            	@@ -23,3 +23,3 @@
2024-05-16T11:51:49.6973693Z         	            	   attrs: ([16]uint8) (len=16) {
2024-05-16T11:51:49.6974766Z         	            	-   00000000  e7 06 68 4c 11 31 91 33  89 87 4d 2e 04 c3 20 a0  |..hL.1.3..M... .|
2024-05-16T11:51:49.6976013Z         	            	+   00000000  4c 1a 0c e2 cd 53 27 eb  ea 97 5f 10 fe ac 21 bd  |L....S'..._...!.|
2024-05-16T11:51:49.6977105Z         	            	   }
2024-05-16T11:51:49.6977593Z         	Test:       	TestLimitEvict
2024-05-16T11:51:49.6977994Z 
2024-05-16T11:51:49.6978174Z DONE 2 runs, 74 tests, 2 failures in 5.570s
@crobert-1 crobert-1 added the needs triage New item requiring triage label May 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1
Copy link
Member Author

+1 freq: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/9193562452/job/25284945313#step:5:102

@crobert-1 crobert-1 mentioned this issue May 22, 2024
Merged
@github-actions github-actions bot mentioned this issue May 28, 2024
Closed
@crobert-1
Copy link
Member Author

+1 freq: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/9271731041/job/25507908106#step:5:102

@sh0rez
Copy link
Member

sh0rez commented May 28, 2024 •
edited
Loading

ack, fixed: #33266

@sh0rez sh0rez mentioned this issue May 28, 2024
Merged
@crobert-1 crobert-1 added flaky test a test is flaky and removed needs triage New item requiring triage labels May 29, 2024
codeboten added a commit that referenced this issue May 31, 2024
@sh0rez @jpkrohling @codeboten
[processor/deltatocumulative]: fix TestLimitEvict (#33266)
88eba8f 
due to undefined map iteration order, this test was flaky

Fixes #33094

Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky test a test is flaky processor/deltatocumulative
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[processor/deltatocumulative]: fix TestLimitEvict sh0rez/opentelemetry-collector-contrib
2 participants
@sh0rez @crobert-1