Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create internal/arrow package for common code used in otelarrowexporter, otelarrowreceiver #33567

Closed
3 tasks
jmacd opened this issue Jun 14, 2024 · 5 comments
Closed
3 tasks

Create internal/arrow package for common code used in otelarrowexporter, otelarrowreceiver #33567

jmacd opened this issue Jun 14, 2024 · 5 comments
Labels
exporter/otelarrow receiver/otelarrow

Comments

@jmacd
Copy link
Contributor

jmacd commented Jun 14, 2024

The purpose and use-cases of the new component

There is some shared code that lives in the otel-arrow repository that depends on unstable collector APIs. It will be a headache to continue maintaining these shared libraries because of it, and it would help to create internal/arrow for all the common code used in these two components.

Example configuration for the component

No config, just an internal group of packages. These include:

  • netstats: counting network bytes compressed and uncompressed (generally useful)
  • admission: limiting receiver in-flight data size (generally useful)
  • compression: improved Zstd configuration support (generally useful)
  • testdata, testutil: common test helpers (arrow-specific)

Telemetry data types supported

All

Is this a vendor-specific component?

  • This is a vendor-specific component
  • If this is a vendor-specific component, I am a member of the OpenTelemetry organization.
  • If this is a vendor-specific component, I am proposing to contribute and support it as a representative of the vendor.

Code Owner(s)

jmacd, moh-osman3

Sponsor (optional)

No response

Additional context

No response
@jmacd jmacd added Sponsor Needed New component seeking sponsor needs triage New item requiring triage exporter/otelarrow receiver/otelarrow and removed Sponsor Needed New component seeking sponsor labels Jun 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for exporter/otelarrow: @jmacd @moh-osman3 @codeboten. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for receiver/otelarrow: @jmacd @moh-osman3. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1
Copy link
Member

Sounds good!

Removing needs triage as it makes sense to me and was filed by a code owner.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Jun 14, 2024
@jmacd jmacd mentioned this issue Jun 14, 2024
Open
@jmacd jmacd assigned jmacd and unassigned jmacd Jun 14, 2024
@jmacd jmacd mentioned this issue Jun 14, 2024
Merged
This was referenced Jun 19, 2024
Closed
Closed
Closed
Closed
Closed
Closed
@odubajDT
Copy link
Contributor

Hi, I would like to work on this cc @evan-bradley

@odubajDT
Copy link
Contributor

Just for clarification, do I understand correctly that the dependencies on github.com/open-telemetry/otel-arrow/pkg and github.com/open-telemetry/otel-arrow/api will stay also after moving the business logic from other packages from otel-arrow repository to internal/arrow?

Thank you

@jmacd jmacd mentioned this issue Jul 8, 2024
Merged
codeboten added a commit that referenced this issue Jul 17, 2024
@jmacd @codeboten @mwear
Add internal/otelarrow package for shared code between otelarrow expo…
7e3fc98 
…rter, receiver (#33579)

**Description:** The otelarrowexporter and otelarrowreceiver components
depend on several libraries in the open-telemetry/otel-arrow repository,
which would complicate release management in both repositories. This
change eliminates the dependency on `otel-arrow/collector` by moving
each of those packages into a subdirectory of `internal/otelarrow`.

**Link to tracking Issue:** #33567 

**Testing:** This brings new integration tests into this repository for
the two otelarrow components.

**Documentation:** Each of the three non-test packages exposed here has
a brief README.md explaining why it exists. Each of these could be
useful to non-Arrow components if helpful.

---------

Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Co-authored-by: Matthew Wear <matthew.wear@gmail.com>
This was referenced Jul 17, 2024
Merged
Merged
codeboten added a commit that referenced this issue Jul 17, 2024
@jmacd @codeboten
Use internal/otelarrow in exporter/otelarrowexporter (#34137)
2997a90 
**Description:** Removes external dependencies.

**Link to tracking Issue:** #33567

---------

Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten pushed a commit that referenced this issue Jul 19, 2024
@jmacd
Use internal/otelarrow in receiver/otelarrowreceiver (#34138)
c389bb2 
**Description:** Removes external dependencies.

**Link to tracking Issue:** #33567
@jmacd jmacd closed this as completed Jul 19, 2024
@jmacd jmacd mentioned this issue Jul 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exporter/otelarrow receiver/otelarrow
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jmacd @crobert-1 @odubajDT