Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/logdedup] Add OTTL Condition Field to logdedup processor #35440

Closed
colelaven opened this issue Sep 26, 2024 · 4 comments · Fixed by #35443
Closed

[processor/logdedup] Add OTTL Condition Field to logdedup processor #35440

colelaven opened this issue Sep 26, 2024 · 4 comments · Fixed by #35443
Labels
enhancement New feature or request processor/logdedup

Comments

@colelaven
Copy link
Contributor

Component(s)

processor/logdedup

Is your feature request related to a problem? Please describe.

It would be useful to have a condition field on the logdedup processor to only perform the deduplication on logs that pass said condition.

Describe the solution you'd like

Add a condition field to the logdedup processor. Only logs that pass this condition are deduped.

Describe alternatives you've considered

No response

Additional context

No response

@colelaven colelaven added enhancement New feature or request needs triage New item requiring triage labels Sep 26, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@colelaven colelaven changed the title Add OTTL Condition Field to logdedup processor [processor/logdedup] Add OTTL Condition Field to logdedup processor Sep 26, 2024
@colelaven
Copy link
Contributor Author

colelaven commented Sep 26, 2024

I have a code change ready for this one, putting a PR out soon.

@BinaryFissionGames
Copy link
Contributor

It makes sense to me that you may have some logs that are more "low-latency" or you otherwise want to omit from deduplication.

@BinaryFissionGames
Copy link
Contributor

/label -needs-triage

@github-actions github-actions bot removed the needs triage New item requiring triage label Sep 26, 2024
djaglowski pushed a commit that referenced this issue Oct 8, 2024
…35443)

**Description:**

Adds OTTL Condition field to Deduplicate Logs Processor

**Link to tracking Issue:** Closes #35440 

**Testing:** 
- Tested functionality with BindPlane
- Added unit tests for the condition logic

**Documentation:** Added documentation to the logdedup processor README
about the condition field and an example configuration with a condition.

---------

Co-authored-by: Mike Goldsmith <goldsmith.mike@gmail.com>
ghost pushed a commit to sematext/opentelemetry-collector-contrib that referenced this issue Oct 9, 2024
…pen-telemetry#35443)

**Description:**

Adds OTTL Condition field to Deduplicate Logs Processor

**Link to tracking Issue:** Closes open-telemetry#35440 

**Testing:** 
- Tested functionality with BindPlane
- Added unit tests for the condition logic

**Documentation:** Added documentation to the logdedup processor README
about the condition field and an example configuration with a condition.

---------

Co-authored-by: Mike Goldsmith <goldsmith.mike@gmail.com>
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
…pen-telemetry#35443)

**Description:**

Adds OTTL Condition field to Deduplicate Logs Processor

**Link to tracking Issue:** Closes open-telemetry#35440 

**Testing:** 
- Tested functionality with BindPlane
- Added unit tests for the condition logic

**Documentation:** Added documentation to the logdedup processor README
about the condition field and an example configuration with a condition.

---------

Co-authored-by: Mike Goldsmith <goldsmith.mike@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request processor/logdedup
Projects
None yet
2 participants