Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadogreceiver] api/v1/series returns OK, instead of JSON status: ok #35743

Closed
wiardvanrij opened this issue Oct 11, 2024 · 1 comment · Fixed by #35744
Closed

[datadogreceiver] api/v1/series returns OK, instead of JSON status: ok #35743

wiardvanrij opened this issue Oct 11, 2024 · 1 comment · Fixed by #35744
Labels
bug Something isn't working needs triage New item requiring triage receiver/datadog

Comments

@wiardvanrij
Copy link
Contributor

wiardvanrij commented Oct 11, 2024

Component(s)

receiver/datadog

What happened?

Description

https://docs.datadoghq.com/api/latest/metrics/?code-lang=go

Response should be

{
  "status": "ok"
}
image

However, the receiver response with a string OK: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/receiver/datadogreceiver/receiver.go#L286

Why this matters

For example here: https://github.com/apache/airflow/blob/39f8e1d487ab8f1969aaec512fdffacca989813c/providers/src/airflow/providers/datadog/hooks/datadog.py#L68

The body is checked, which is causing failures.

Collector version

latest

Environment information

No response

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

@wiardvanrij wiardvanrij added bug Something isn't working needs triage New item requiring triage labels Oct 11, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
…e on par with DD api spec (open-telemetry#35744)

#### Description
Changes the responses to be on par with the datadog api spec as per:
https://docs.datadoghq.com/api/latest/metrics/?code-lang=go

#### Link to tracking issue
Fixes open-telemetry#35743

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Unit test is updated

<!--Describe the documentation added.-->
#### Documentation
Added changelog, no other docs seem to be required
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage New item requiring triage receiver/datadog
Projects
None yet
1 participant