Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract scraper test code into common package #5741

Closed
djaglowski opened this issue Oct 13, 2021 · 1 comment · Fixed by #5755
Closed

Extract scraper test code into common package #5741

djaglowski opened this issue Oct 13, 2021 · 1 comment · Fixed by #5755
Assignees
Labels
data:metrics Metric related issues

Comments

@djaglowski
Copy link
Member

The newly added receivers for httpd and mysql have essentially the same test code for validating an expected result.

This code may be useful elsewhere eventually, but it would seem there is an immediate benefit to pulling into into a common package. I suggest we start with a internal/scrapertest. Potentially, this can eventually move into core if it has proves to be broadly useful.

@djaglowski
Copy link
Member Author

@Mrod1598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:metrics Metric related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant