Move Scraper test functionality to seperate package #5755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
reviewed
Oct 15, 2021
djaglowski
reviewed
Oct 19, 2021
|
Also, separated out the compare function into multiple different funcs for easier readability. Also, it could be helpful to compare at different levels. |
djaglowski
reviewed
Oct 22, 2021
djaglowski
reviewed
Oct 22, 2021
djaglowski
reviewed
Oct 22, 2021
djaglowski
reviewed
Oct 22, 2021
|
@Mrod1598 I like where this is going. A few more things to address, but overall this is what I wanted to see. @dmitryax, you might be interested to evaluate this. I expect this would be a very useful testing pattern for scrapers. Initially the package is proposed as internal, but could move elsewhere if/when appropriate. |
djaglowski
reviewed
Oct 22, 2021
added 2 commits
October 22, 2021 12:35
djaglowski
reviewed
Oct 22, 2021
djaglowski
reviewed
Oct 25, 2021
djaglowski
approved these changes
Oct 26, 2021
djaglowski
added
the
ready to merge
|
@Mrod1598 please resolve the conflicts |
bogdandrutu
removed
the
ready to merge
|
@djaglowski please readd the label when PR is rebased |
resolved |
djaglowski
added
the
ready to merge
bogdandrutu
approved these changes
Oct 29, 2021
|
@Mrod1598 Please resolve conflicts |
djaglowski
removed
the
ready to merge
djaglowski
added
the
ready to merge
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Moved common scraper test code to separate package
Link to tracking Issue:
Resolves #5741
Testing:
Added testing to confirm testing ability of CompareMetrics Func.