Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/elasticsearch] support sending otlp tracing to Elasticsearch #10180

Merged
merged 46 commits into from
Sep 8, 2022
Merged

[exporter/elasticsearch] support sending otlp tracing to Elasticsearch #10180

merged 46 commits into from
Sep 8, 2022

Conversation

JaredTan95
Copy link
Member

@JaredTan95 JaredTan95 commented May 20, 2022 •
edited
Loading

Signed-off-by: jian.tan jian.tan@daocloud.io

support and close #12069
Description: support sending otlp tracing to Elasticsearch

image

@JaredTan95 JaredTan95 requested review from a team and codeboten May 20, 2022 02:01
@Frapschen
Copy link
Contributor

cool

@JaredTan95 JaredTan95 mentioned this pull request May 20, 2022
Closed
6 tasks
@dmitryax
Copy link
Member

dmitryax commented May 20, 2022 •
edited
Loading

@JaredTan95 please fix linter/test failures

@JaredTan95
Copy link
Member Author

@JaredTan95 please fix linter/test failures

done :-)

@JaredTan95
Copy link
Member Author

JaredTan95 commented Jun 1, 2022 •
edited
Loading

@codeboten @dmitryax hi, Do you have time to help review the code? :-P

@JaredTan95
fix conflicts
b828971 
Signed-off-by: jian.tan <jian.tan@daocloud.io>
@JaredTan95
update README.md
eb34cf6 
Signed-off-by: jian.tan <jian.tan@daocloud.io>
@JaredTan95
fix fmt
9ed6b03 
Signed-off-by: jian.tan <jian.tan@daocloud.io>
@JaredTan95
fix lint
db3fc26 
Signed-off-by: jian.tan <jian.tan@daocloud.io>
@JaredTan95
fix make goporto
14e9b87 
Signed-off-by: jian.tan <jian.tan@daocloud.io>
@JaredTan95
fix ut.
c01468c 
Signed-off-by: jian.tan <jian.tan@daocloud.io>
@JaredTan95
fix conf
193ce99 
Signed-off-by: jian.tan <jian.tan@daocloud.io>
@JaredTan95
Merge branch 'main' into es_exporter_otlp_tracing
394af91
@JaredTan95
Copy link
Member Author

BTW, In the future, whether we need to add the sending_queue logic to ensure that the data lost?

dmitryax
dmitryax reviewed Jun 29, 2022
View reviewed changes
exporter/elasticsearchexporter/factory.go Outdated Show resolved Hide resolved
exporter/elasticsearchexporter/config.go Outdated Show resolved Hide resolved
@dmitryax
Copy link
Member

cc @urso @faec @blakerouse as code owners, PTAL

@JaredTan95
fix ut
7b4f9de 
Signed-off-by: jian.tan <jian.tan@daocloud.io>
@JaredTan95
Copy link
Member Author

@jpkrohling @codeboten @dmitryax hi, this PR ready to review :)

JaredTan95 and others added 3 commits August 15, 2022 11:09
@JaredTan95 @dmitryax
Update exporter/elasticsearchexporter/logs_exporter.go
a4abcb3 
Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
@JaredTan95
Merge branch 'main' into es_exporter_otlp_tracing
b7bde8a
@JaredTan95
update deprecated
dc456a0 
Signed-off-by: jian.tan <jian.tan@daocloud.io>
dmitryax
dmitryax approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pinging code owners as well @urso @faec @blakerouse

@dmitryax
Copy link
Member

I would be good to have at least one approval from code owners before merging it

@jpkrohling
Copy link
Member

jpkrohling commented Aug 22, 2022 •
edited
Loading

It would be good to have a review from a current code owner as well: cc @urso @faec @blakerouse

@jpkrohling jpkrohling closed this Aug 22, 2022
@jpkrohling jpkrohling reopened this Aug 22, 2022
@jpkrohling
Copy link
Member

Sorry for closing/opening, I clicked the wrong button.

@JaredTan95
Copy link
Member Author

hi, @urso @faec @blakerouse do you have time to help review this feature PR?

@ramdaspotale
Copy link

Hi, @JaredTan95

I am eagerly waiting for this PR to be completed as soon as possible, as this functionality is much needed in my case. can you please review failed required checks and help to merge this?

@JaredTan95
fix lint
c47978a 
Signed-off-by: jian.tan <jian.tan@daocloud.io>
@dmitryax dmitryax merged commit 25d4ed7 into open-telemetry:main Sep 8, 2022
@JaredTan95 JaredTan95 deleted the es_exporter_otlp_tracing branch September 8, 2022 03:08
@evan-bradley evan-bradley mentioned this pull request Sep 9, 2022
Closed
This was referenced Sep 27, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

@codeboten codeboten Awaiting requested review from codeboten

@jpkrohling jpkrohling Awaiting requested review from jpkrohling

Assignees

@dmitryax dmitryax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[exporter/elasticsearch] support sending otlp tracing to Elasticsearch
5 participants
@JaredTan95 @Frapschen @dmitryax @jpkrohling @ramdaspotale