Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheusreceiver] Add attributes from target_info metric #11034

Merged
merged 4 commits into from
Jun 23, 2022

Conversation

gouthamve
Copy link
Member

Link to tracking Issue: #8265

@gouthamve gouthamve requested a review from a team June 14, 2022 15:56
@gouthamve gouthamve force-pushed the target-info-receiver branch from fe91f1b to a8a88d6 Compare June 15, 2022 07:17
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
@gouthamve gouthamve force-pushed the target-info-receiver branch from 8be5836 to e14a036 Compare June 16, 2022 09:08
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TylerHelmuth TylerHelmuth added the ready to merge Code review completed; ready to merge by maintainers label Jun 21, 2022
@mx-psi
Copy link
Member

mx-psi commented Jun 23, 2022

@gouthamve does this completely fix #8265?

@mx-psi mx-psi merged commit ed54587 into open-telemetry:main Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants