[prometheusexporter] Export target_info metrics #11514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @dashpole |
dashpole
reviewed
Jun 23, 2022
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
dashpole
approved these changes
Jul 11, 2022
|
lgtm, assuming you fix the build failures from rebasing |
gouthamve
force-pushed
the
export-target-info-prometheusexporter
branch
from
bf512ce to
0c13330
Compare
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
gouthamve
force-pushed
the
export-target-info-prometheusexporter
branch
from
0c13330 to
f9fb6bf
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
dashpole
added
exporter/prometheus
ready to merge
mx-psi
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finally fixes #8265
The issue is that we have the resource attributes sent in each metric, and we need to dedupe to unique resourceAttributes based on job + instance labels.
I kinda hacked together something, not sure if this is the way to go. Looking forward to some feedback before I proceed further.