-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/awscontainerinsightsreceiver] Pod Detection changes for K8's in containerd runtime #11666
Conversation
@@ -303,6 +306,9 @@ spec: | |||
- name: varlibdocker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it safe to retain this even if the path doesn't exist on the host?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is safe to retain the path, reference from the container-d supported version of yaml.
and in viceversa tested this from local on EKS 1.22 version with this yaml file
@@ -117,7 +117,9 @@ func processContainer(info *cInfo.ContainerInfo, mInfo extractors.CPUMemInfoProv | |||
namespace := info.Spec.Labels[namespaceLabel] | |||
podName := info.Spec.Labels[podNameLabel] | |||
podID := info.Spec.Labels[podIDLabel] | |||
if containerName == "" || namespace == "" || podName == "" { | |||
// NOTE: containerName can be empty for pause container on containerd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to validate that this is not a pause container before entering this branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there actually isn't a way to do this validation. 😕
receiver/awscontainerinsightreceiver/internal/cadvisor/extractors/extractor.go
Outdated
Show resolved
Hide resolved
unreleased/detect-pod.yaml
Outdated
@@ -0,0 +1,16 @@ | |||
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | |||
change_type: breaking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't a breaking change, is it? It doesn't change exported APIs at all. It seems more like an enhancement to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, thanks for the suggestion
Description:
dockershim will be deprecated in the latest kubernetes release. Due to this following changes in PR are required when using
containerd
runtimepod detection logic relies on pause container with name 'POD`, which is only the case for docker
update all the manifest to mount containerd
EKS Announcement: Amazon EKS is ending support for dockershim
Link to tracking Issue:
Documentation:
CHANGELOG.md