Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/dockerstatsreceiver] Initial PR to onboard dockerstats onto mdatagen #12322
[receiver/dockerstatsreceiver] Initial PR to onboard dockerstats onto mdatagen #12322
Changes from all commits
2bfdcfc
dbea8b9
96a0518
86a2c6c
ba3a74a
b474d88
ddd4c43
3ada5d6
e4406b4
c9c00d6
c1cbbc2
191b48b
f81c212
b4a2538
da4b203
178b39e
3d7eb46
c646c0f
121fa2d
a800ec5
e0be23c
8ff4540
1955866
a12f0e7
8cfeb4f
a1ec764
5a9dd28
c36a27f
612b144
7ac8631
7d34f6d
3ab8923
771456b
9aa9a96
6547cf0
2709245
c51d3be
a8f1cb0
d7f4afd
3750d20
a4aac5b
c396e60
fb33b3b
e6d74f2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we have reverted the
go-connections
version, does this still need to happen?Or is this just a safe nice to have?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it doesn't need to be there anymore, but imo it doesn't hurt to leave it in, and it could be nice to have for future purposes or similar issues. I don't feel strongly either way
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.