Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/metricstransform] Remove deprecated metric_name setting #12737

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Jul 26, 2022

The setting was deprecated more than a year ago. It's time to remove it

@dmitryax dmitryax requested review from a team and codeboten July 26, 2022 20:44
@dmitryax dmitryax merged commit d4ff1dc into open-telemetry:main Jul 26, 2022
note: Remove deprecatedetric_me settings option

# One or more tracking issues related to the change
issues: [12601]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a correct issue

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, #12740

henriquesantanati added a commit to henriquesantanati/ecsdemo-amp that referenced this pull request Nov 2, 2022
Updating the file to fix the Open-telemetry deprecations as per below:

* [Remove deprecated metric_name setting #12737](open-telemetry/opentelemetry-collector-contrib#12737) - It was replaced by `include` as per [the docs](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/processor/metricstransformprocessor)
* [awsprometheusremotewriteexporter deprecation notice](https://pkg.go.dev/github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awsprometheusremotewriteexporter#section-readme) - Users who want to send metrics to Amazon Managed Service for Prometheus will need to instead use the [Prometheus Remote Write Exporter](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/exporter/prometheusremotewriteexporter/README.md) along with the [Sigv4 Authenticator Extension](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/extension/sigv4authextension/README.md) to achieve the same result.
maishsk pushed a commit to aws-samples/ecsdemo-amp that referenced this pull request Feb 6, 2023
Updating the file to fix the Open-telemetry deprecations as per below:

* [Remove deprecated metric_name setting #12737](open-telemetry/opentelemetry-collector-contrib#12737) - It was replaced by `include` as per [the docs](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/processor/metricstransformprocessor)
* [awsprometheusremotewriteexporter deprecation notice](https://pkg.go.dev/github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awsprometheusremotewriteexporter#section-readme) - Users who want to send metrics to Amazon Managed Service for Prometheus will need to instead use the [Prometheus Remote Write Exporter](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/exporter/prometheusremotewriteexporter/README.md) along with the [Sigv4 Authenticator Extension](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/extension/sigv4authextension/README.md) to achieve the same result.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants