[pkg/stanza] Unexport and organize fields on manager struct #12793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These fields are currently meant only for internal use.
djaglowski
force-pushed
the
pkg-stanza-fileconsumer-cleanup-names
branch
from
b7e0c53
to
043e116
Compare
TylerHelmuth
reviewed
Aug 1, 2022
djaglowski
removed
the
Skip Changelog
|
Thanks for the review @TylerHelmuth. I doubt anyone was using these fields, but you're right. I've added a changelog entry. |
TylerHelmuth
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fields are currently meant only for internal use.
Additionally, this reorganizes the fields within the
Inputstruct,to follow some roughly logical grouping around concern/usage.