Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Instana exporter #13747

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

hickeyma
Copy link
Contributor

Signed-off-by: Martin Hickey martin.hickey@ie.ibm.com

Description:

This is the third of 3 PRs which adds the new component, Instana exporter. This PR
enables the exporter.

Link to tracking Issue:

Closes #13395

Testing:

Integration test

Documentation:

README updated

@hickeyma hickeyma requested a review from a team August 31, 2022 10:53
@hickeyma hickeyma requested a review from jpkrohling as a code owner August 31, 2022 10:53
@hickeyma hickeyma force-pushed the enable-instana-exporter branch from e6c48d7 to d400b04 Compare August 31, 2022 13:06
@hickeyma hickeyma marked this pull request as draft August 31, 2022 13:25
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hickeyma hickeyma marked this pull request as ready for review August 31, 2022 15:33
@hickeyma hickeyma marked this pull request as draft August 31, 2022 15:36
@hickeyma hickeyma marked this pull request as draft August 31, 2022 15:36
@hickeyma
Copy link
Contributor Author

hickeyma commented Aug 31, 2022

Need to fix go.sum.

@hickeyma hickeyma marked this pull request as ready for review August 31, 2022 21:29
@hickeyma hickeyma force-pushed the enable-instana-exporter branch from d400b04 to 126eefc Compare September 1, 2022 09:09
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
@hickeyma hickeyma force-pushed the enable-instana-exporter branch from 126eefc to 09ce0c7 Compare September 1, 2022 09:17
@hickeyma
Copy link
Contributor Author

hickeyma commented Sep 1, 2022

@jpkrohling Fixed the CI issues, needed to updated cmd/configschema/go.mod. PTAL again.

@hickeyma hickeyma requested a review from jpkrohling September 1, 2022 10:33
@jpkrohling jpkrohling merged commit 79c4a6a into open-telemetry:main Sep 1, 2022
@hickeyma hickeyma deleted the enable-instana-exporter branch September 1, 2022 12:07
@hickeyma
Copy link
Contributor Author

hickeyma commented Sep 1, 2022

Thanks @jpkrohling for reviews and merge

@hickeyma
Copy link
Contributor Author

hickeyma commented Sep 1, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New component: Instana Exporter
4 participants