Disable TestTrace10kSPS/AwsXray #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testbed/tests/trace_test.go
Outdated
Comment on lines
62
to
71
| // Disabled due to instability. Issue #1380 | ||
| // { | ||
| // "AwsXray", | ||
| // testbed.NewOTLPTraceDataSender("localhost", testbed.GetAvailablePort(t)), | ||
| // datareceivers.NewMockAwsXrayDataReceiver(testbed.GetAvailablePort(t)), | ||
| // testbed.ResourceSpec{ | ||
| // ExpectedMaxCPU: 75, | ||
| // ExpectedMaxRAM: 85, | ||
| // }, | ||
| // }, |
There was a problem hiding this comment.
Please delete the code, we don't allow commented code. It is already recorded as an issue.
tigrannajaryan
approved these changes
Oct 27, 2020
mx-psi
referenced
this pull request
in DataDog/opentelemetry-collector-contrib
Oct 27, 2020
Adding #1387 to make CI pass more easily
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
* Add release documentation * fix formatting
dmitryax
added a commit
to dmitryax/opentelemetry-collector-contrib
that referenced
this pull request
Jan 11, 2024
The test using this mock receiver was disabled more than 3 years ago open-telemetry#1387 and never restored after that. Proposing to remove the dead code to reduce the maintenance overhead.
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Feb 1, 2024
The test using this mock receiver was disabled more than 3 years ago open-telemetry#1387 and never restored after that. Proposing to remove the dead code to reduce the maintenance overhead. Pinging code owner @wangzlei, @srprash. Let us know if it's ok to remove if you want to revive the test instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1380