-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pkg/opentelemetrytransformationlanguage] Rename TQL to OTTL #14150
Conversation
Not opposed to shortening the package directory to |
cc @kovrus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a handful of places where lowercase tql
is replaced with uppercase OTTL
. There are a handful of places where OTTLotel
is specified in import paths where I didn't comment on every one. I've highlighted once instance, it should be easy to find and replace the rest.
As for renaming the directory to pkg/oteltransformationlanguage
, I think that would make sense since the current name is so long. Abbreviations are common in component names (e.g. k8s
or attrs
), and otel
is already used in internal/otelcontribcore
, so I think there's some precedent for it as well.
pkg/opentelemetrytransformationlanguage/functions/ottlcommon/README.md
Outdated
Show resolved
Hide resolved
pkg/opentelemetrytransformationlanguage/functions/ottlotel/func_delete_matching_keys.go
Outdated
Show resolved
Hide resolved
@evan-bradley I think I addressed all your feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a few additional replacements needed in a readme, but otherwise looks good.
@evan-bradley @bogdandrutu @kentquirk @kovrus please take a look. |
Description:
Renames TQL to OTTL. No functional changes
Link to tracking Issue:
Resolves #13919
Testing:
Unit tests
Documentation:
All documentation/links have been updated