Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/opentelemetrytransformationlanguage] Rename TQL to OTTL #14150

Merged
merged 13 commits into from
Sep 21, 2022

Conversation

TylerHelmuth
Copy link
Member

Description:
Renames TQL to OTTL. No functional changes

Link to tracking Issue:
Resolves #13919

Testing:
Unit tests

Documentation:
All documentation/links have been updated

@TylerHelmuth
Copy link
Member Author

Not opposed to shortening the package directory to oteltransformationlanguage

@jpkrohling
Copy link
Member

cc @kovrus

Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a handful of places where lowercase tql is replaced with uppercase OTTL. There are a handful of places where OTTLotel is specified in import paths where I didn't comment on every one. I've highlighted once instance, it should be easy to find and replace the rest.

As for renaming the directory to pkg/oteltransformationlanguage, I think that would make sense since the current name is so long. Abbreviations are common in component names (e.g. k8s or attrs), and otel is already used in internal/otelcontribcore, so I think there's some precedent for it as well.

@TylerHelmuth
Copy link
Member Author

TylerHelmuth commented Sep 16, 2022

@evan-bradley I think I addressed all your feedback.

Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a few additional replacements needed in a readme, but otherwise looks good.

processor/routingprocessor/README.md Outdated Show resolved Hide resolved
processor/routingprocessor/README.md Outdated Show resolved Hide resolved
@TylerHelmuth
Copy link
Member Author

@evan-bradley @bogdandrutu @kentquirk @kovrus please take a look.

@bogdandrutu bogdandrutu merged commit ea5818a into open-telemetry:main Sep 21, 2022
@TylerHelmuth TylerHelmuth deleted the rename-tql branch September 21, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename "TQL" (telemetry query language) for better clarity while it's still painless to do so
4 participants