[receiver/solacereceiver] Updates Solace Receiver for compatibility with Solace PubSub+ Event Broker 10.2.0 #15244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SOL-75196
SOL-75870, SOL-74853
This allows forward compatibility in the event that new entries are added in the future SOL-78861
OpenTelemetry+backends do not support the Bytes type, and instead support a slice of integers SOL-78624
…perties" This reverts commit 48b9730.
…dpoint name> enqueue', even for anonymous endpoints Also removes messaging.destination as an attribute on enqueue events as its now redundant SOL-79098
In this case, the message will be dropped and stats incremented SOL-79796
Working around Azure/go-amqp#126 by batching dispositions SOL-79806
This reverts commit bf61326.
djaglowski
reviewed
Oct 18, 2022
|
@djaglowski added it, though at first added it to unreleased rather than .chloggen. All fixed now. |
Thanks for pointing that out. Looks like we had a few PRs slip through after the change. |
djaglowski
approved these changes
Oct 18, 2022
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
…ith Solace PubSub+ Event Broker 10.2.0 (open-telemetry#15244) * Use modify message instead of reject message to indicate failure SOL-75279 * Set delivery mode on propagated spans SOL-75196 * Added character type to user property mapping SOL-75145 * Changed dropped_user_properties to dropped_application_message_properties SOL-74920 * Updated protobuf spec, incorporated transactional changes SOL-75362 * Scoped metrics to receiver instances based on instance name if present SOL-75870, SOL-74853 * Made delivery mode mapped strings lowercase SOL-75196 * Use string of length 1 instead of int for character value mapping SOL-75145 * Gracefully handle enums beyond the current known set This allows forward compatibility in the event that new entries are added in the future SOL-78861 * Use the slice type in the attribute map when mapping user properties OpenTelemetry+backends do not support the Bytes type, and instead support a slice of integers SOL-78624 * Revert "Use the slice type in the attribute map when mapping user properties" This reverts commit 48b9730. * Change name of Enqueue Event in OpenTelemetry Spans to always be '<endpoint name> enqueue', even for anonymous endpoints Also removes messaging.destination as an attribute on enqueue events as its now redundant SOL-79098 * Handle the case of an empty payload, returning an error In this case, the message will be dropped and stats incremented SOL-79796 * Fixed an issue causing AcceptMessage to hang indefinitely Working around Azure/go-amqp#126 by batching dispositions SOL-79806 * Revert "Fixed an issue causing AcceptMessage to hang indefinitely" This reverts commit bf61326.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: A variety of fixes and improvements. Most notably:
Link to tracking Issue: None
Testing: For all changes and fixes, tests have been added/updated
Documentation: No major changes to documentation
@djaglowski