[kafka Exporter] refactor tests #16265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Considering this is to refactor tests, I wasn't sure if it would need an issue and a changelog entry. |
MovieStoreGuy
force-pushed
the
msg/chore-refactor-kafka-exporter-test
branch
from
4852c45
to
4086476
Compare
MovieStoreGuy
force-pushed
the
msg/chore-refactor-kafka-exporter-test
branch
from
4086476
to
676c75d
Compare
These tests needed a little love to make it easier to contribute to the component
Co-authored-by: Alex Boten <alex@boten.ca>
MovieStoreGuy
force-pushed
the
msg/chore-refactor-kafka-exporter-test
branch
from
d655af8
to
692195d
Compare
codeboten
approved these changes
Nov 18, 2022
JaredTan95
pushed a commit
to openinsight-proj/opentelemetry-collector-contrib
that referenced
this pull request
Nov 21, 2022
These tests needed a little love to make it easier to contribute to the component Co-authored-by: Alex Boten <alex@boten.ca>
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
These tests needed a little love to make it easier to contribute to the component Co-authored-by: Alex Boten <alex@boten.ca>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests needed a little love to make it easier to contribute to the component.
I wanted to improve these tests update to help move #16100 along :)