Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Testbed network usage reporting, new OTLP-gRPC compression settings test cases #16835

Closed
wants to merge 1 commit into from

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Dec 9, 2022

Description:

Adds optional support to the testbed for scraping the /metrics endpoint of the collector under test. Coupled with proposed obsreport metrics support, this change reports on the compression performance and network bandwidth used.

Depends on open-telemetry/opentelemetry-collector#6712.

Also: this code looks to be in need of some maintenance. I removed a repetitive bit of code used in every test while I was applying the same fix to the OTLP test sender/receiver. See the new ExporterCreateSettings() helper.

Link to tracking Issue:

Part of open-telemetry/opentelemetry-collector#6638.

Testing:

Ran the standard testbed tests, with output for the OTLP-* cases (including gRPC which is instrumented and HTTP which is not):

Test                                    |Result|Duration|CPU Avg%|CPU Max%|RAM Avg MiB|RAM Max MiB|Sent Items|Received Items|MiB/sec in  |MiB/sec out |I/O Comp    |In Comp     |Out Comp    
----------------------------------------|------|-------:|-------:|-------:|----------:|----------:|---------:|-------------:|-----------:|-----------:|-----------:|-----------:|----------:|
Trace10kSPS/OTLP-gRPC-gzipIn-plainOut   |PASS  |     15s|     5.5|     8.2|         54|         78|    150000|        150000|      1.2876|     21.4445|     16.1002|      0.0600|      1.0000|            
Trace10kSPS/OTLP-gRPC-plainIn-plainOut  |PASS  |     15s|     4.4|     5.8|         47|         67|    150000|        150000|     21.4513|     21.4445|      0.9992|      1.0003|      1.0000|            
Trace10kSPS/OTLP-gRPC-gzipIn-gzipOut    |PASS  |     16s|     6.1|     7.6|         54|         77|    150000|        150000|      1.2862|      1.0411|      0.7841|      0.0600|      0.0485|            
Trace10kSPS/OTLP-gRPC-plainIn-gzipOut   |PASS  |     15s|     5.5|     7.0|         53|         76|    149900|        149900|     21.4370|      1.0424|      0.0487|      1.0003|      0.0486|            
Trace10kSPS/OTLP-gRPC-plainIn-zstdOut   |PASS  |     15s|     4.3|     6.6|         97|        161|    150000|        150000|     21.4513|      0.6824|      0.0319|      1.0003|      0.0318|            
Trace10kSPS/OTLP-gRPC-gzipIn-zstdOut    |PASS  |     15s|     5.3|     7.4|        104|        171|    149900|        149900|      1.2880|      0.6842|      0.5146|      0.0601|      0.0319|            
Trace10kSPS/OTLP-HTTP                   |PASS  |     15s|     4.4|     5.8|         47|         66|    149900|        149900|            |            |            |            |            |            
Trace10kSPS/OTLP-HTTP-gzip              |PASS  |     15s|     5.7|     7.5|         48|         68|    150000|        150000|            |            |            |            |            |            

@jmacd
Copy link
Contributor Author

jmacd commented Dec 15, 2022

Note: Discussion and motivation in open-telemetry/opentelemetry-collector#6638.

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Dec 30, 2022
@github-actions
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant