-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Loki as a log exporter (first PR: overall structure) #1900
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1900 +/- ##
==========================================
+ Coverage 89.90% 89.91% +0.01%
==========================================
Files 380 382 +2
Lines 18335 18383 +48
==========================================
+ Hits 16484 16529 +45
- Misses 1385 1387 +2
- Partials 466 467 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@open-telemetry/collector-contrib-approvers @anuraaga - Looking forward to working with you and getting Loki added as an exporter. Per the contributing docs, the second PR will include the implementation, and the third will add it to the binary. |
LGTM |
…nal and non-conventional attribute names
Thank you so much for reviewing, @anuraaga! I have addressed your comments and look forward to your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple more readme nits but LGTM, thanks
Thank you so much, @anuraaga! |
@anuraaga - Are you authorized to merge this? |
What are the next steps to getting this merged, @anuraaga? |
@gramidt We need a maintainer to merge this after the initial review. I guess people are on holidays so we may need to wait until next week. |
Sounds good! Thank you again for all of your help, @anuraaga! |
@gramidt consider to add an entry in the codeowners for this component as well as for the dependabot |
Thank you so much for your help in getting this merged, @bogdandrutu! I'll be sure to commit the entrees for the codeowners. |
Bumps [github.com/jaegertracing/jaeger](https://github.com/jaegertracing/jaeger) from 1.19.2 to 1.20.0. - [Release notes](https://github.com/jaegertracing/jaeger/releases) - [Changelog](https://github.com/jaegertracing/jaeger/blob/master/CHANGELOG.md) - [Commits](jaegertracing/jaeger@v1.19.2...v1.20.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Remove the Tracer method from the Span API * Update CHANGELOG with changes * Update CHANGELOG.md * Fix misspell * Address feedback
Description:
Allow exporting of log data to Loki.
Link to tracking Issue:
#1894
Testing:
Unit tests are included
Documentation:
The documentation includes a short description and the configuration.