-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spanmetricsprocessor #1914
Add spanmetricsprocessor #1914
Conversation
Signed-off-by: albertteoh <albert.teoh@logz.io>
Apologies in advance for the largish diff; I thought it would be more useful for reviewers to have the full context rather a portion of the picture. Most of the diff is composed of tests, sample/test config, generated mocks and documentation. However, if it would help reviewers to reduce the diff size, please advise how you wish each partial diff to be structured and I can close this PR and create the smaller diffs as advised. |
Codecov Report
@@ Coverage Diff @@
## master #1914 +/- ##
==========================================
+ Coverage 89.95% 90.04% +0.09%
==========================================
Files 381 384 +3
Lines 18519 18698 +179
==========================================
+ Hits 16659 16837 +178
- Misses 1390 1391 +1
Partials 470 470
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Exciting work, @albertteoh! I can't wait to test it out. Typically when adding new components, the following PR order is recommended in the contributing docs.
|
Thanks @gramidt! Closing this PR and will start with a new PR containing the overall structure as advised. |
…1914) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.37.0 to 1.37.1. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.37.0...v1.37.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: albertteoh albert.teoh@logz.io
Description:
Adds a new processor for aggregating span data to produce Requests Error and Duration (R.E.D) metrics.
Note: as advised by maintainers during the Agent/Collector SIG, a workaround configuration of adding a dummy receiver and pipeline is required due to current limitations of the pipeline design and constraints.
Link to tracking Issue: #403
Testing:
prometheusremotewrite
exporter.Documentation:
config.go
for detailed configuration instructions.