Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lokiexporter: Add to binary #2387

Closed
wants to merge 1 commit into from
Closed

lokiexporter: Add to binary #2387

wants to merge 1 commit into from

Conversation

gramidt
Copy link
Member

@gramidt gramidt commented Feb 20, 2021

Description:
Add the Loki exporter to the binary, so members of the community can start utilizing it without requiring a custom build.

Link to tracking Issue:
#1894

Testing:
Several iterations of this exporter have been used in a private distribution of the collector with minimal issues. All issues identified through testing have been resolved and enhancements have been documented via GH Issues.

Documentation:
https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/exporter/lokiexporter/README.md

Signed-off-by: Granville Schmidt 1246157+gramidt@users.noreply.github.com

Signed-off-by: Granville Schmidt <1246157+gramidt@users.noreply.github.com>
@gramidt gramidt requested a review from a team February 20, 2021 23:45
@codecov
Copy link

codecov bot commented Feb 20, 2021

Codecov Report

Merging #2387 (c08deec) into main (e43c235) will increase coverage by 0.97%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2387      +/-   ##
==========================================
+ Coverage   72.72%   73.70%   +0.97%     
==========================================
  Files         410      411       +1     
  Lines       25355    25432      +77     
==========================================
+ Hits        18440    18745     +305     
+ Misses       6368     6133     -235     
- Partials      547      554       +7     
Flag Coverage Δ
integration 69.22% <0.00%> (?)
unit 72.72% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/otelcontribcol/components.go 87.17% <100.00%> (+0.16%) ⬆️
internal/common/testing/container/container.go 73.68% <0.00%> (ø)
receiver/jmxreceiver/receiver.go 94.80% <0.00%> (+16.88%) ⬆️
receiver/dockerstatsreceiver/docker.go 92.30% <0.00%> (+39.05%) ⬆️
receiver/dockerstatsreceiver/receiver.go 96.72% <0.00%> (+47.54%) ⬆️
receiver/jmxreceiver/subprocess/subprocess.go 96.55% <0.00%> (+74.48%) ⬆️
receiver/redisreceiver/receiver.go 87.50% <0.00%> (+87.50%) ⬆️
receiver/redisreceiver/client.go 100.00% <0.00%> (+100.00%) ⬆️
receiver/redisreceiver/factory.go 100.00% <0.00%> (+100.00%) ⬆️
...eceiver/jmxreceiver/subprocess/subprocess_linux.go 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e43c235...c08deec. Read the comment docs.

@gramidt
Copy link
Member Author

gramidt commented Feb 21, 2021

Closing PR as there are some gaps in coverage that were not caught in earlier PRs. Will re-open after they're addressed.

@gramidt gramidt closed this Feb 21, 2021
kisieland referenced this pull request in kisieland/opentelemetry-collector-contrib Mar 16, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants