Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] fix exhaustive lint for groupbyattrs processor #24068

Merged
merged 1 commit into from
Jul 12, 2023
Merged

[chore] fix exhaustive lint for groupbyattrs processor #24068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,9 +170,6 @@ issues:
- path: deltatorateprocessor
linters:
- exhaustive
- path: groupbyattrsprocessor
linters:
- exhaustive
- path: filterprocessor
linters:
- exhaustive
Expand Down
2 changes: 2 additions & 0 deletions processor/groupbyattrsprocessor/processor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ func (gap *groupByAttrsProcessor) processMetrics(ctx context.Context, md pmetric
dataPoint.CopyTo(groupedMetric.ExponentialHistogram().DataPoints().AppendEmpty())
}

case pmetric.MetricTypeEmpty:
}
}
}
Expand Down Expand Up @@ -222,6 +223,7 @@ func getMetricInInstrumentationLibrary(ilm pmetric.ScopeMetrics, searchedMetric
case pmetric.MetricTypeSummary:
metric.SetEmptySummary()

case pmetric.MetricTypeEmpty:
}

return metric
Expand Down