Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/kubeletstatsreceiver] prepend container. metrics with k8s. #24388

Closed

Conversation

mackjmr
Copy link
Member

@mackjmr mackjmr commented Jul 19, 2023

Description:
This PR introduces k8s.container* metrics, which will replace their container.* metrics counterparts. For now, the k8s.container* metrics are disabled by default.

The following process will be followed to phase out the old metrics:

  • In v0.82.0, the new metric is introduced and the old metric is marked as deprecated. Only the old metric are emitted by default.
  • In v0.84.0, the old metric is disabled and the new one enabled by default.
  • In v0.86.0 and up, the old metric is removed.

Please refer to the following issue: #24238 for the reason for this change.

Link to tracking Issue:
#24238

This PR introduces `k8s.container*` metrics, which will replace their `container.*` metrics counterparts. For now, the `k8s.container*` metrics are disabled by default.

The following process will be followed to phase out the old metrics:
- In `v0.82.0`, the new metric is introduced and the old metric is marked as deprecated.
  Only the old metric are emitted by default.
- In `v0.84.0`, the old metric is disabled and the new one enabled by default.
- In `v0.86.0` and up, the old metric is removed.

Please refer to the following issue: open-telemetry#24238 for the reason for this change.
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I agree with the proposal. Let's continue the discussion in #24238

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Aug 4, 2023
@mx-psi mx-psi removed the Stale label Aug 4, 2023
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Aug 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2023

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants