Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/opensearch] Add OpenSearchExporter to otelcontribcol #24668

Merged
merged 1 commit into from
Nov 24, 2023
Merged

[exporter/opensearch] Add OpenSearchExporter to otelcontribcol #24668

merged 1 commit into from
Nov 24, 2023

Conversation

MaxKsyunz
Copy link
Contributor

This PR completes addition of OpenSearch exporter.

@MaxKsyunz MaxKsyunz force-pushed the opensearchexporter-pub branch from 87a077d to 3e35461 Compare July 29, 2023 11:26
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Aug 13, 2023
@MaxKsyunz MaxKsyunz force-pushed the opensearchexporter-pub branch from 3e35461 to 8ea951f Compare August 22, 2023 01:00
@github-actions github-actions bot removed the Stale label Aug 22, 2023
@MaxKsyunz MaxKsyunz force-pushed the opensearchexporter-pub branch 3 times, most recently from 06a2195 to f0348ea Compare August 24, 2023 07:20
@MaxKsyunz MaxKsyunz marked this pull request as ready for review August 24, 2023 19:06
@MaxKsyunz MaxKsyunz requested a review from a team August 24, 2023 19:06
@MaxKsyunz MaxKsyunz requested a review from Aneurysm9 as a code owner August 25, 2023 02:50
mx-psi
mx-psi approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Note that this PR does not make the open search exporter available in the Contrib distribution. To do this, you need to file a PR against the manifest available over at opentelemetry-collector-releases

@mx-psi mx-psi added the ready to merge Code review completed; ready to merge by maintainers label Aug 28, 2023
dmitryax
dmitryax reviewed Aug 29, 2023
View reviewed changes
.chloggen/add-opensearchexporter.yaml Outdated
component: opensearchexporter

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Add opensearchexporter to otelcontribcol
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the exporter to the development build isn't a customer-facing change. This line should call out the promotion of the component to the Alpha stability level instead.

.chloggen/add-opensearchexporter.yaml Outdated
@@ -0,0 +1,10 @@
# Use this changelog template to create an entry for release notes.

change_type: new_component
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
change_type: new_component
change_type: enhancement

Given that it was already mentioned as a new component in 0.82.0

@mx-psi mx-psi removed the ready to merge Code review completed; ready to merge by maintainers label Sep 1, 2023
@MaxKsyunz MaxKsyunz force-pushed the opensearchexporter-pub branch from 3159bf9 to 3486d77 Compare September 1, 2023 19:45
@MaxKsyunz
Copy link
Contributor Author

@dmitryax your comments have been addressed -- thanks for taking a look.

@MaxKsyunz
Copy link
Contributor Author

@mx-psi is this good to merge?

@mx-psi mx-psi requested a review from dmitryax September 7, 2023 07:44
@mx-psi
Copy link
Member

mx-psi commented Sep 8, 2023

@dmitryax PTAL!

@MaxKsyunz MaxKsyunz changed the title [exporter/opensearch] Include OpenSearchExporter in release [exporter/opensearch] Add OpenSearchExporter to otelcontribcol Sep 11, 2023
@mx-psi
Copy link
Member

mx-psi commented Sep 28, 2023

do you know what's keeping this PR from getting ready to merge label? Once I get thumbs of from someone, I'll address merge conflicts.

I was waiting on @dmitryax to give their approval. Since we have an approval from someone else we can merge once you solve the merge conflicts

This was referenced Oct 3, 2023
Closed
Open
@bryan-aguilar
Copy link
Contributor

@MaxKsyunz I'm going to drop the ready to merge label until merge conflicts are resolved.

@bryan-aguilar bryan-aguilar removed the ready to merge Code review completed; ready to merge by maintainers label Oct 4, 2023
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 19, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 3, 2023

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Nov 3, 2023
@mx-psi mx-psi reopened this Nov 3, 2023
@mx-psi
Copy link
Member

mx-psi commented Nov 3, 2023

@MaxKsyunz Gentle reminder that I will merge this once merge conflicts are addressed :)

@github-actions github-actions bot removed the Stale label Nov 4, 2023
@MaxKsyunz
Copy link
Contributor Author

@MaxKsyunz Gentle reminder that I will merge this once merge conflicts are addressed :)

@mx-psi my apologies -- I was away from GitHub. Thank you for keeping this PR alive. :)

I'll push an update soon.

@MaxKsyunz MaxKsyunz force-pushed the opensearchexporter-pub branch 5 times, most recently from d8d44cb to f82d250 Compare November 10, 2023 02:39
@sumobrian
Copy link

Are the unresolved test failures preventing this branch from being merged? The branch conflicts were addressed last week, but new conflicts have since emerged.

@mx-psi
Copy link
Member

mx-psi commented Nov 14, 2023

The branch conflicts were addressed last week, but new conflicts have since emerged.

There are still branch conflicts, we can't merge until these are solved and tests pass:

image

@sumobrian
Copy link

The branch conflicts were addressed last week, but new conflicts have since emerged.

There are still branch conflicts, we can't merge until these are solved and tests pass:

image

Copy. For a brief period there were no conflicts BUT all tests were not passing.

@MaxKsyunz MaxKsyunz force-pushed the opensearchexporter-pub branch 3 times, most recently from 93e3d86 to 10f91e1 Compare November 23, 2023 23:03
@MaxKsyunz
Add opensearchexporter to otelcontribcol
4d5cd14 
Signed-off-by: Max Ksyunz <max.ksyunz@improving.com>
@MaxKsyunz MaxKsyunz force-pushed the opensearchexporter-pub branch from 10f91e1 to 4d5cd14 Compare November 24, 2023 07:45
@MaxKsyunz
Copy link
Contributor Author

@mx-psi all checks are green.

@mx-psi mx-psi merged commit c173bbf into open-telemetry:main Nov 24, 2023
83 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 24, 2023
@YANG-DB YANG-DB mentioned this pull request Dec 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YANG-DB YANG-DB YANG-DB approved these changes

@fatsheep9146 fatsheep9146 fatsheep9146 approved these changes

@mx-psi mx-psi mx-psi approved these changes

@atoulme atoulme atoulme approved these changes

@pmcollins pmcollins Awaiting requested review from pmcollins

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@dmitryax dmitryax Awaiting requested review from dmitryax

Assignees

@fatsheep9146 fatsheep9146

Labels
cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command cmd/oteltestbedcol exporter/opensearch
Projects
None yet
Milestone
v0.90.0
Development

Successfully merging this pull request may close these issues.
8 participants
@MaxKsyunz @mx-psi @bryan-aguilar @sumobrian @atoulme @dmitryax @fatsheep9146 @YANG-DB