Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore]Use Right file name for the prometheus compliance tests #24729

Merged
merged 8 commits into from
Sep 6, 2023
Merged

[chore]Use Right file name for the prometheus compliance tests #24729

Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
071337a
Use Right file name for the compliance
vasireddy99 Jul 31, 2023
4e180fc
Add Note
vasireddy99 Aug 24, 2023
dfec807
Wording changes
vasireddy99 Aug 25, 2023
aa9ce6c
Merge branch 'main' into fixcom
vasireddy99 Aug 26, 2023
45c1088
Merge branch 'main' into fixcom
vasireddy99 Aug 28, 2023
af85a1e
Merge branch 'main' into fixcom
vasireddy99 Aug 28, 2023
1dc9903
Merge branch 'main' into fixcom
vasireddy99 Aug 30, 2023
5726fd1
Merge branch 'main' into fixcom
Aneurysm9 Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/prometheus-compliance-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,10 @@ jobs:
with:
repository: prometheus/compliance
path: compliance
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we checkout a specific commit/tag?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I am not sure if we need to checkout specific tag. Since I see the tests are stable now at the main/recent commit.

ref: f0482884578bac67b053e3eaa1ca7f783d146557
- name: Copy binary to compliance directory
run: mkdir compliance/remote_write_sender/bin && cp opentelemetry-collector-contrib/bin/otelcontribcol_linux_amd64 compliance/remote_write_sender/bin/otelcol_linux_amd64
# The required name of the downloaded artifact is `otelcol_0.42.0_linux_amd64`, so we place the collector contrib artifact under the same name in the bin folder to run.
# Source: https://github.com/prometheus/compliance/blob/12cbdf92abf7737531871ab7620a2de965fc5382/remote_write_sender/targets/otel.go#L8
run: mkdir compliance/remote_write_sender/bin && cp opentelemetry-collector-contrib/bin/otelcontribcol_linux_amd64 compliance/remote_write_sender/bin/otelcol_0.42.0_linux_amd64
vasireddy99 marked this conversation as resolved.
Show resolved Hide resolved
- name: Run compliance tests
run: go test -v --tags=compliance -run "TestRemoteWrite/otel/.+" ./ |& tee ./test-report.txt
working-directory: compliance/remote_write_sender