Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[receiver/prometheus] Don't drop Histograms without buckets" #24766

Closed
wants to merge 1 commit into from
Closed

Revert "[receiver/prometheus] Don't drop Histograms without buckets" #24766

wants to merge 1 commit into from

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Aug 1, 2023

Reverts #23448 to fix failing unit tests on main:

--- FAIL: TestOpenMetricsInvalid (7.38s)
    --- FAIL: TestOpenMetricsInvalid/invalid_histograms_11 (0.00s)
        metrics_receiver_open_metrics_test.go:[126](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/5726440203/job/15516921980#step:8:127): 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusreceiver/metrics_receiver_open_metrics_test.go:126
            	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusreceiver/metrics_receiver_helper_test.go:635
            	Error:      	Not equal: 
            	            	expected: 6
            	            	actual  : 5
            	Test:       	TestOpenMetricsInvalid/invalid_histograms_11
FAIL

see e.g. this run

@mx-psi mx-psi requested review from a team and swiatekm August 1, 2023 12:56
@github-actions github-actions bot added the receiver/prometheus Prometheus receiver label Aug 1, 2023
@mx-psi mx-psi mentioned this pull request Aug 1, 2023
Merged
@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 1, 2023
@dashpole
Copy link
Contributor

dashpole commented Aug 1, 2023

cc @swiatekm-sumo

@mx-psi
Copy link
Member Author

mx-psi commented Aug 1, 2023

@swiatekm-sumo is actively working on a fix, will leave this up to merge if needed but give him a bit of time to try and fix this without the revert

@mx-psi
Copy link
Member Author

mx-psi commented Aug 1, 2023

Closing in favor of #24767

@mx-psi mx-psi closed this Aug 1, 2023
@bogdandrutu bogdandrutu deleted the revert-23448-fix/prometheusreceiver/empty-histogram branch September 10, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@swiatekm swiatekm Awaiting requested review from swiatekm

Assignees

@Aneurysm9 Aneurysm9

Labels
receiver/prometheus Prometheus receiver Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mx-psi @dashpole @TylerHelmuth @Aneurysm9