[cmd/mdatagen] Mdatagen support histogram metrics #26558
Conversation
|
Occasional e2e-tests(kubernetes-test) failures, hello @atoulme seems to PR restart job on failure try to solve that.
|
| func (m *metric{{ $name.Render }}) recordDataPoint(start pcommon.Timestamp, ts pcommon.Timestamp, val {{ $metric.Data.MetricValueType.BasicType }} | ||
| {{- range $metric.Attributes -}}, {{ .RenderUnexported }}AttributeValue {{ (attributeInfo .).Type.Primitive }}{{ end }}) { | ||
| func (m *metric{{ $name.Render }}) recordDataPoint(start pcommon.Timestamp, ts pcommon.Timestamp | ||
| {{- if eq $metric.Data.Type "Histogram" }}, count uint64, sum float64 |
There was a problem hiding this comment.
What about bucket values? Histograms without buckets are invalid
There was a problem hiding this comment.
Done. Thanks for reviewing my code. I realize that I overlooked the details in docs data-model_Histogram, spec_Histogram and proto_Histogram
There was a problem hiding this comment.
Hello @dmitryax , would you be available to help review the code again if possible, i would like to assist in resolving this issue, thanks
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Could this PR hold on? |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
sakulali
force-pushed
the
fix-metadata-generator-histogram
branch
from
28459d8 to
69ed578
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
sakulali
force-pushed
the
fix-metadata-generator-histogram
branch
from
69ed578 to
7eaa323
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Description:
Metadata generator support histogram metrics
Link to tracking Issue:
#26118
Testing:
make generate
make mdatagen-test
make chlog-validate
Documentation:
cmd/mdatagen/documentation.md