-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] add first integration test for telemetrygen #26668
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overlaps with #26566? cc @fatsheep9146 |
atoulme
force-pushed
the
add_test_of_traces
branch
from
September 13, 2023 16:54
e0045f2
to
de06b2d
Compare
I don't think it overlaps all that much, they both have value imo :) |
I believe this is also related to #26068 (another issue requesting e2e tests for telemetrygen). |
atoulme
force-pushed
the
add_test_of_traces
branch
4 times, most recently
from
September 14, 2023 22:55
a332159
to
f6c6f4a
Compare
mx-psi
reviewed
Sep 19, 2023
please fix the conflict |
atoulme
force-pushed
the
add_test_of_traces
branch
from
September 22, 2023 22:04
f0a2e1a
to
3f7c66a
Compare
mx-psi
approved these changes
Sep 25, 2023
This was referenced Oct 19, 2023
mx-psi
added a commit
that referenced
this pull request
Oct 20, 2023
sigilioso
pushed a commit
to carlossscastro/opentelemetry-collector-contrib
that referenced
this pull request
Oct 27, 2023
…emetry#27878) **Description:** Move `cmd/telemetrygen` integration tests to separate module, to avoid local replaces. Follow up to open-telemetry#26668. **Link to tracking Issue:** Fixes open-telemetry#27855
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…6668) It shows trace ingest with otlp. Relates to open-telemetry#26659
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…emetry#27878) **Description:** Move `cmd/telemetrygen` integration tests to separate module, to avoid local replaces. Follow up to open-telemetry#26668. **Link to tracking Issue:** Fixes open-telemetry#27855
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It shows trace ingest with otlp.
Relates to #26659