Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] add first integration test for telemetrygen #26668

Merged
merged 5 commits into from
Sep 25, 2023

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Sep 13, 2023

It shows trace ingest with otlp.

Relates to #26659

@atoulme atoulme requested a review from a team September 13, 2023 14:56
@github-actions github-actions bot added the cmd/telemetrygen telemetrygen command label Sep 13, 2023
@mx-psi
Copy link
Member

mx-psi commented Sep 13, 2023

Overlaps with #26566? cc @fatsheep9146

@atoulme
Copy link
Contributor Author

atoulme commented Sep 13, 2023

I don't think it overlaps all that much, they both have value imo :)

@crobert-1
Copy link
Member

crobert-1 commented Sep 13, 2023

I believe this is also related to #26068 (another issue requesting e2e tests for telemetrygen).

@fatsheep9146
Copy link
Contributor

please fix the conflict

@mx-psi mx-psi merged commit 88c3225 into open-telemetry:main Sep 25, 2023
92 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 25, 2023
mx-psi added a commit that referenced this pull request Oct 20, 2023
**Description:** 

Move `cmd/telemetrygen` integration tests to separate module, to avoid
local replaces. Follow up to #26668.

**Link to tracking Issue:** Fixes #27855
sigilioso pushed a commit to carlossscastro/opentelemetry-collector-contrib that referenced this pull request Oct 27, 2023
…emetry#27878)

**Description:** 

Move `cmd/telemetrygen` integration tests to separate module, to avoid
local replaces. Follow up to open-telemetry#26668.

**Link to tracking Issue:** Fixes open-telemetry#27855
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
…emetry#27878)

**Description:** 

Move `cmd/telemetrygen` integration tests to separate module, to avoid
local replaces. Follow up to open-telemetry#26668.

**Link to tracking Issue:** Fixes open-telemetry#27855
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/telemetrygen telemetrygen command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants