Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg/stanza] propagate globbing io errors for logging #26713

Merged
merged 8 commits into from
Sep 20, 2023
Merged

[pkg/stanza] propagate globbing io errors for logging #26713

merged 8 commits into from
Sep 20, 2023

Conversation

haoqixu
Copy link
Member

@haoqixu haoqixu commented Sep 15, 2023

Description:
Set WithFailOnIOErrors option and propagate the globbing io errors for logging.

Link to tracking Issue:
resolve #23768

@haoqixu haoqixu requested a review from djaglowski as a code owner September 15, 2023 18:57
@haoqixu haoqixu requested a review from a team September 15, 2023 18:57
@haoqixu
Copy link
Member Author

haoqixu commented Sep 16, 2023

I make some changes becase I noticed that the globbing errors was returned too early and the behavior was changed.
The globbing error is used for warning and the finder shoud still try its best to find as many valid paths as possible. When an error is returned with the WithFailOnIOErrors option, we shoud do the glob again without WithFailOnIOErrors.

@haoqixu haoqixu requested a review from atoulme September 16, 2023 18:10
haoqixu and others added 4 commits September 20, 2023 11:00
@haoqixu @djaglowski
Update pkg/stanza/fileconsumer/matcher/matcher.go
02322d7 
Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
@haoqixu @djaglowski
Update pkg/stanza/fileconsumer/matcher/matcher.go
8a7fe27 
Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
@haoqixu @djaglowski
Update pkg/stanza/fileconsumer/matcher/matcher.go
91113cc 
Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
@haoqixu
chore: add a comment
1435400
djaglowski
djaglowski approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement @haoqixu

@djaglowski djaglowski merged commit cca42e0 into open-telemetry:main Sep 20, 2023
@github-actions github-actions bot added this to the next release milestone Sep 20, 2023
@haoqixu haoqixu mentioned this pull request Nov 7, 2023
Closed
6 tasks
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
@haoqixu @jmsnll
[pkg/stanza] propagate globbing io errors for logging (open-telemetry…
4126416 
…#26713)

Set `WithFailOnIOErrors` option and propagate the globbing io errors for logging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djaglowski djaglowski djaglowski approved these changes

@atoulme atoulme Awaiting requested review from atoulme

Assignees

@TylerHelmuth TylerHelmuth

Labels
pkg/stanza
Projects
None yet
Milestone
v0.86.0
Development

Successfully merging this pull request may close these issues.

[receiver/filelog]: Log glob IO errors
4 participants
@haoqixu @atoulme @djaglowski @TylerHelmuth