-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(syslogreceiver): validate protocol name #27581
Merged
djaglowski
merged 3 commits into
open-telemetry:main
from
sumo-drosiek:drosiek-syslog-improvement
Oct 11, 2023
Merged
feat(syslogreceiver): validate protocol name #27581
djaglowski
merged 3 commits into
open-telemetry:main
from
sumo-drosiek:drosiek-syslog-improvement
Oct 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumo-drosiek
commented
Oct 10, 2023
sumo-drosiek
commented
Oct 10, 2023
sumo-drosiek
commented
Oct 10, 2023
andrzej-stencel
approved these changes
Oct 11, 2023
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
sumo-drosiek
force-pushed
the
drosiek-syslog-improvement
branch
from
October 11, 2023 11:54
90b5316
to
f68d134
Compare
djaglowski
approved these changes
Oct 11, 2023
JaredTan95
pushed a commit
to openinsight-proj/opentelemetry-collector-contrib
that referenced
this pull request
Oct 18, 2023
**Description:** Add validation of protocol name and be case insensitive **Link to tracking Issue:** **Testing:** Unit Tests **Documentation:** N/A --------- Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
**Description:** Add validation of protocol name and be case insensitive **Link to tracking Issue:** **Testing:** Unit Tests **Documentation:** N/A --------- Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add validation of protocol name and be case insensitive
Link to tracking Issue:
Testing:
Unit Tests
Documentation:
N/A